D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-06 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:0354fd11f1f0: KIO/SMB convert kio protocol declaration to 
json format (authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26358?vs=72743=72900

REVISION DETAIL
  https://phabricator.kde.org/D26358

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb.cpp
  smb/smb.json
  smb/smb.protocol

To: meven, #frameworks, ngraham
Cc: elvisangelaccio, apol, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-06 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Well, at least it doesn't hurt anything and it's more technically correct. :)

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: elvisangelaccio, apol, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-06 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: elvisangelaccio, apol, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven added a comment.


  In D26358#587596 , @ngraham wrote:
  
  > BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :(
  
  
  I mistested this, and removed the "BUG: 414482" accordingly.
  
  I don't reproduce this bug locally unfortunately myself. I would have been 
happy to fix it.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Nathaniel Graham 
ngraham added a comment.


  BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :(

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven updated this revision to Diff 72743.
meven added a comment.


  Update commit message

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26358?vs=72742=72743

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26358

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb.cpp
  smb/smb.json
  smb/smb.protocol

To: meven, #frameworks, ngraham
Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven added a comment.


  I have tested it and it solves https://bugs.kde.org/show_bug.cgi?id=414482
  It seems .protocol file support has some issue.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven updated this revision to Diff 72742.
meven marked 4 inline comments as done.
meven added a comment.


  Fix json

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26358?vs=72596=72742

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26358

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb.cpp
  smb/smb.json
  smb/smb.protocol

To: meven, #frameworks, ngraham
Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Pino Toscano 
pino added inline comments.

INLINE COMMENTS

> smb.json:27
> +"output": "filesystem",
> +"protocol": "recentlyused",
> +"reading": true,

erm...

> smb.protocol:11
> -deleting=true
> -opening=true
> -moving=true

what about this key?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-04 Thread Méven Car 
meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> apol wrote in kio_smb.cpp:42
> Shouldn't this go in the SMBSlave class?

No this is fine, this is done the same way in trash, file, recentlyused 
io~slaves...
Follows https://github.com/shortstheory/kioslave-tutorial

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-02 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> kio_smb.cpp:42
> +Q_OBJECT
> +Q_PLUGIN_METADATA(IID "org.kde.kio.slave.smb" FILE "smb.json")
> +};

Shouldn't this go in the SMBSlave class?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-01 Thread Méven Car 
meven added a comment.


  Not too sure if it helps bug https://bugs.kde.org/show_bug.cgi?id=414482

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-01 Thread Méven Car 
meven added a reviewer: ngraham.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-01 Thread Méven Car 
meven created this revision.
meven added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26358

AFFECTED FILES
  recentlyused/recentlyused.cpp
  smb/CMakeLists.txt
  smb/kio_smb.cpp
  smb/smb.json
  smb/smb.protocol

To: meven, #frameworks
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26358: KIO/SMB convert kio protocol declaration to json format

2020-01-01 Thread Méven Car 
meven updated this revision to Diff 72596.
meven added a comment.


  clean

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26358?vs=72595=72596

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26358

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb.cpp
  smb/smb.json
  smb/smb.protocol

To: meven, #frameworks
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov