D26532: Don't use KWindowSystem on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:33742dde2f73: Dont use KWindowSystem on Android (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26532?vs=73095=73343 REVISION

D26532: Don't use KWindowSystem on Android

dfaure accepted this revision. dfaure added a comment. I agree with the reasoning, we can break BC on Android. REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause, apol, dfaure Cc: dfaure,

D26532: Don't use KWindowSystem on Android

apol accepted this revision. REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause, apol Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

nicolasfella added a subscriber: dfaure. nicolasfella added a comment. Pragmatically speaking I want to say 'No'. @dfaure Do you have an opinion on this? REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella,

D26532: Don't use KWindowSystem on Android

vkrause added a comment. In D26532#590609 , @nicolasfella wrote: > In D26532#590598 , @vkrause wrote: > > > We are already not building a few things here on Android (including public API on other

D26532: Don't use KWindowSystem on Android

nicolasfella added a comment. In D26532#590598 , @vkrause wrote: > We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't

D26532: Don't use KWindowSystem on Android

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an

D26532: Don't use KWindowSystem on Android

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D26513: Port KNotification from KWindowSystem. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n,

D26532: Don't use KWindowSystem on Android

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The usage of KWindowSystem is not relevant on Android.