D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

gvgeo added a comment. F8071207: alignment.png This shows the problem. Don't know what is the correct approach: 1 Label needs to be shorter, like PC3. 2 Give correct height in checkbox, and center the buttons. 3 Override label height in

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601718 , @gvgeo wrote: > Plasma theme explorer is fine. The difference is that it uses plasmaComponents, while D26271 uses plasmaComponents**3**. > > About

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

gvgeo added a comment. @ndavis Any chance you missed my previous comment? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg, ngraham Cc: gvgeo, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

gvgeo added a comment. Plasma theme explorer is fine. The difference is that it uses plasmaComponents, while D26271 uses plasmaComponents**3**. About plasmaComponents: There is some bug with the checkbox and the Label. Fails to take the correct

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ad625f68f345: Fix the size and pixel alignment of checkboxes and radiobuttons (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks visually broken in the exact same way in Plasma Theme Explorer, so I suspect the test code was lifted from it which explains why it's broken in the test. Looks perfect in

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601675 , @ngraham wrote: > I'd like to be able to verify that by looking at a radio button in the Plasma style but I can't actually find any. Do you know of any place where they're used?

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ngraham added a comment. I'd like to be able to verify that by looking at a radio button in the Plasma style but I can't actually find any. Do you know of any place where they're used? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To:

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In case it's not clear or for anyone skimming the conversation, I think the tests themselves are broken and can't be relied upon because they break things that normally work OK or at least better than they do in the tests. I don't know QML that well, but I don't see

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601535 , @ngraham wrote: > Found one small regression in the test suite. The new correct radio button sizing results in vertical misalignment (for both PC2 and PC3): > > Status quo: F7978647:

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ngraham added a comment. Found one small regression in the test suite. The new correct radio button sizing results in vertical misalignment (for both PC2 and PC3): Status quo: F7978647: Screenshot_20200127_112436.PNG With patch: F7978654:

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. Ping. This patch doesn't fix everything, but it's still an improvement over the current state. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg Cc: davidedmundson, kde-frameworks-devel,

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#599231 , @davidedmundson wrote: > Please be sure to run the relevant tests in > > tests/components/ > > with qmlscene > > It'll find more than running random applets Unfortunately, those have

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

davidedmundson added a comment. Please be sure to run the relevant tests in tests/components/ with qmlscene It'll find more than running random applets REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis retitled this revision from "[WIP] Fix the size and pixel alignment of checkboxes and radiobuttons" to "Fix the size and pixel alignment of checkboxes and radiobuttons". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis,