cordlandwehr closed this revision.
cordlandwehr added a comment.
arc land was not automatically detected, landed with commit:
https://cgit.kde.org/kconfig.git/commit/?id=43d4f1276b3afe259907add9b458f15252514fa4
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D27601
cordlandwehr updated this revision to Diff 78213.
cordlandwehr added a comment.
Merge branch 'master' into spdx
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27601?vs=76675=78213
BRANCH
spdx
REVISION DETAIL
https://phabricator.kde.org/D27601
cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
R237 KConfig
BRANCH
spdx
REVISION DETAIL
https://phabricator.kde.org/D27601
To: cordlandwehr, cgiboudeaux
Cc: ognarb, cgiboudeaux, kde-frameworks-devel,
cordlandwehr marked 3 inline comments as done.
cordlandwehr added a comment.
Reverted license change for the XSD file. Right now I do not see any
equivalent in the SPDX registry.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D27601
To: cordlandwehr
Cc: ognarb,
cordlandwehr updated this revision to Diff 76675.
cordlandwehr added a comment.
Reverting DTD license change
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27601?vs=76403=76675
BRANCH
spdx
REVISION DETAIL
https://phabricator.kde.org/D27601
AFFECTED
ognarb added inline comments.
INLINE COMMENTS
> cordlandwehr wrote in kcfg.xsd:20
> Actually, I though quite a time about this and at the end did a comparison of
> the permissions specifically provided by this statement: use, copy and modify
> (yet there is no explicit statement of
cordlandwehr updated this revision to Diff 76403.
cordlandwehr added a comment.
Better handling of explenatory texts
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27601?vs=76224=76403
BRANCH
spdx
REVISION DETAIL
https://phabricator.kde.org/D27601
cordlandwehr marked 3 inline comments as done.
cordlandwehr added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in kcfg.xsd:20
> What makes you think it's BSD?
Actually, I though quite a time about this and at the end did a comparison of
the permissions specifically provided by this
cgiboudeaux added inline comments.
INLINE COMMENTS
> kconfigbackend_p.h:6
> +
> +Portions:
> +SPDX-FileCopyrightText: 1997 Matthias Kalle Dalheimer
I don't think this is useful
> kconfigini_p.h:6
>
> - This library is free software; you can redistribute it and/or
> - modify it
cordlandwehr added a task: T11550: Add SPDX License markers.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D27601
To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.
REVISION SUMMARY
Convert license headers to SPDX statements and add
license files as required by REUSE specification.
11 matches
Mail list logo