niccolove updated this revision to Diff 79740.
niccolove added a comment.
Removed merged look, no longer needed, but kept rounded corners change
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28372?vs=78742=79740
BRANCH
ngraham added a comment.
The second image definitely looks better than the first. However I wonder if
we could even combine them into just one row. For toolbars with nothing but
icons-only buttons, they kind of feel like they're screaming out to be
integrated into the header.
For
niccolove added a subscriber: manueljlin.
niccolove added a comment.
Generally speaking, I'd still like for all applets to have a row of
plasmoidheading on the bottom of system tray's own because having just system
tray plasmoidheading, especially with the new small font, does not feel
ngraham added a comment.
Awesome, might be something to explore!
I think this patch should probably go in too, since even if we have
headerbar-style headers, there are still going to be cases where we'll want a
second row to put more controls in. But yeah, for the common case of just a
ahiemstra added subscribers: ndavis, ahiemstra.
ahiemstra added a comment.
The same thing was actually proposed by I think @ndavis a while back, see
https://phabricator.kde.org/T10470#219994 .
To summarize, it's perfectly technically possible and I actually rather like
it.
REPOSITORY
ngraham added a comment.
So I have a heretical thought here: maybe we should consider using a
CSD-style headerbar for system tray plasmoids with toolbar-style controls and
put the controls on the same row as the header.
No wait, hear me out! This pop-up doesn't suffer from most of the
mart added inline comments.
INLINE COMMENTS
> niccolove wrote in PlasmoidHeading.qml:77
> I'd go with no SVG, to make sure that the theme creators will see that it's
> broken and add a merged- look. Keep in mind that the plasmoidheading svg was
> added barely one month ago, and no big Plasma
niccolove marked an inline comment as done.
niccolove added inline comments.
INLINE COMMENTS
> davidedmundson wrote in PlasmoidHeading.qml:77
> What should happen if this is set to merged and someone uses a theme that
> doesn't have a merged- prefix?
>
> The old SVG or no SVG at all?
I'd go
niccolove updated this revision to Diff 78742.
niccolove added a comment.
Specified false by default
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28372?vs=78721=78742
BRANCH
merged-plasmoidheading (branched from master)
REVISION
davidedmundson added inline comments.
INLINE COMMENTS
> PlasmoidHeading.qml:58
> + * If false, the plasmoidheading will display a separator. If true, it
> will be considered merged
> + * with another plasmoidheading and the separator won't be showed.
> + */
Worth writing "the
niccolove added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D28372
To: niccolove, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
niccolove retitled this revision from "Added a merged look to the
plasmoidheading" to "Added a merged look to the plasmoidheading and remove
roundedborders".
niccolove edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
niccolove updated this revision to Diff 78721.
niccolove added a comment.
Removed rounded borders and thus the enabledBorders check
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28372?vs=78719=78721
BRANCH
merged-plasmoidheading
niccolove planned changes to this revision.
niccolove added a comment.
The rounding in the svgs is not necessary.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D28372
To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.
REVISION SUMMARY
Added a merged look (without a separator) so that multiple plasmoidheadings
can be visually merged (e.g.: in
15 matches
Mail list logo
