D29511: Label: Add ping-pong logic

2020-05-10 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.


  Yeah, This should be a new component, or at most enabled by an off-by-default 
property. The default behavior should not change.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson, ngraham
Cc: ngraham, apol, davidedmundson, ognarb, cblack, kde-frameworks-devel, 
LeGast00n, michaelh, bruns

D29511: Label: Add ping-pong logic

2020-05-10 Thread Aleix Pol Gonzalez 
apol added a comment.


  I feel like this could break Labels unknowingly. Maybe it would make sense to 
have an extra scrollToFit (?) property or even another separate component to do 
that.
  
  Seeing things bouncing without the author intending could be worse than 
having the text cut off.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson
Cc: apol, davidedmundson, ognarb, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread patrick j pereira 
patrickelectric added a comment.


  Thanks @davidedmundson and @ognarb, I was able to replicate the issue, I'll 
think a bit more in my approach

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson
Cc: davidedmundson, ognarb, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.


  Plasmacomponents is deprecated please see Plasmacomponents3 then see the 
readme within that and put this somewhere else.
  
  1. Label is a super super super common element we don't want to add any 
overhead instantiating a label. A new special class would be best
  2. It can all be done in one SequentialAnimation, you don't need states.
  3. You don't need to get the width again, we know this already from the other 
text properties.
  4. This is broken for any text that's wrapped or elided

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson
Cc: davidedmundson, ognarb, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread Carl Schwan 
ognarb requested changes to this revision.
ognarb added a comment.
This revision now requires changes to proceed.


  I'm not sure it is a good idea, but at least for me it break the clock in my 
panel.
  
  F8294594: vokoscreenNG-2020-05-07_17-49-49.mkv 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb
Cc: ognarb, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread patrick j pereira 
patrickelectric added a comment.


  Outoput:
  F8294587: deepin-screen-recorder_qmlscene_20200507124715.gif 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread Carson Black 
cblack added a comment.


  You should include a video in the test plan since you're creating visual 
changes with motion.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread patrick j pereira 
patrickelectric updated this revision to Diff 82218.
patrickelectric added a comment.


  Update style

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29511?vs=82217&id=82218

BRANCH
  ping_pong_text

REVISION DETAIL
  https://phabricator.kde.org/D29511

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/Label.qml

To: patrickelectric
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread Carson Black 
cblack added reviewers: Plasma, VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

2020-05-07 Thread patrick j pereira 
patrickelectric created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
patrickelectric requested review of this revision.

REVISION SUMMARY
  Add friendly ping-pong animation to allow visibility of full text
  in an animated way
  
  Signed-off-by: Patrick José Pereira 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ping_pong_text

REVISION DETAIL
  https://phabricator.kde.org/D29511

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/Label.qml

To: patrickelectric
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns