kossebau added a comment.
In https://phabricator.kde.org/D3977#155973, @elvisangelaccio wrote:
> From what I can see, after this change any job registered with
>
> KIO::getJobTracker()->registerJob(job);
>
>
> no longer needs to be manually unregistered with
>
>
elvisangelaccio added a comment.
In https://phabricator.kde.org/D3977#155762, @kossebau wrote:
> On a quick look the automatic unregistering based on the finished signal
seems to make sense for any KJob subclass. Perhaps the change in this commit
conflicts with some older code in Ark to
kossebau added a comment.
In https://phabricator.kde.org/D3977#155721, @elvisangelaccio wrote:
> @kossebau
> After this change we get the
>
> Tried to unregister a kio job that hasn't been registered.
>
> warning with a `KCompositeJob` in Ark (batchextract.cpp).
>
elvisangelaccio added a comment.
@kossebau
After this change we get the
Tried to unregister a kio job that hasn't been registered.
warning with a `KCompositeJob` in Ark (batchextract.cpp).
The job is now automatically unregistered and the `unregisterJob(this)` call
in the
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3261c842a2a9: Fix memleak in KDynamicJobTracker,
KWidgetJobTracker needs QApplication (authored by kossebau).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
kossebau marked an inline comment as done.
kossebau added a comment.
Will commit in a few days, if noone objects. So it has some weeks for testing
outside my system before the next KF release.
REPOSITORY
R241 KIO
BRANCH
fixKDynamicJobTracker
REVISION DETAIL
kossebau updated this revision to Diff 9781.
kossebau marked an inline comment as done.
kossebau added a comment.
Use Q_DECL_OVERRIDE & nullpt
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3977?vs=9775=9781
BRANCH
fixKDynamicJobTracker
REVISION DETAIL
kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.
Rest LGTM, but let's wait for another review
INLINE COMMENTS
> kdynamicjobtrackernowidgetstest.cpp:34
> +public:
> +virtual void start() {
kossebau updated this revision to Diff 9775.
kossebau added a comment.
add unittest for crash by qwidgets without qapplication instance
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3977?vs=9740=9775
BRANCH
fixKDynamicJobTracker
REVISION DETAIL
kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KDynamicJobTracker was not cleaning up its internal job tracking
data structure on finished jobs.
Also was it trying to create a KWidgetJobTracker even
10 matches
Mail list logo
