This revision was automatically updated to reflect the committed changes.
Closed by commit R296:86bbebdee213: Start drag with press and hold on touch
events (authored by davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4972?vs=12273=15978
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
good idea!
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4972
To: davidedmundson, #plasma, mart
Cc: mart, hein, broulik, plasma-devel,
mart added a comment.
the discussion seems to me a bit unrelated with the review in itself.
for me the patch is ok, +1
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4972
To: davidedmundson, #plasma
Cc: mart, hein, broulik, plasma-devel, #frameworks,
broulik added a comment.
Even Qt's own `Drag` attached property crashes when the item it's attached to
is deleted as I had to experience, cf https://phabricator.kde.org/D4976
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4972
To: davidedmundson, #plasma
Cc:
hein added a comment.
So do Task Manager and Folder View. Because DragArea is kind of broken and
will crash Plasma if it's deleted during the drag (which happens quite often
when you remove something by DND).
REPOSITORY
R296 KDeclarative
REVISION DETAIL
davidedmundson added a comment.
Kicker uses a normal mouse area for drag starting, then a different plasmoid
specific C++ helper for mimedata
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4972
To: davidedmundson, #plasma
Cc: broulik, plasma-devel,
broulik added a comment.
Kickoff also uses DragArea iirc, I tend to use Qt's own Drag thing, though,
but if we have better/proper touchscreen support in there then, might be worth
re-considering.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4972
To:
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This patch consists of two changes:
- starting drags on press and hold
- not starting drags when the event
