D5455: Extend Programmer's Guide with notes about influence of setlocale()

This revision was automatically updated to reflect the committed changes. Closed by commit R249:db45cf7242d7: Extend Programmer's Guide with notes about influence of setlocale() (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D5455: Extend Programmer's Guide with notes about influence of setlocale()

ilic accepted this revision. ilic added a comment. All good to me. REPOSITORY R249 KI18n BRANCH addNoteAboutGettextLocaleIssuse REVISION DETAIL https://phabricator.kde.org/D5455 To: kossebau, #frameworks, ilic, aacid Cc: aacid

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. In https://phabricator.kde.org/D5455#107095, @kossebau wrote: > BTW, the `` and `\ref x` seems not to work (only reused that for consistency), will do a separate patch later which follows instructions from

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. BTW, the `` and `\ref x` seems not to work (only reused that for consistency), will do a separate patch later which follows instructions from http://doxygen.10944.n7.nabble.com/Creating-links-in-and-between-Markdown-files-pages-td6689.html REPOSITORY R249 KI18n

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. @ilic Thanks for the comments, agreed. Actually the initial text had some "really?" across it, as I was surprised about the findings stated in there and wanted (your) confirmation. So made this info bit a subsection of the "Writing Messages" part, and changed it

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau updated this revision to Diff 14158. kossebau added a comment. rework text follwing feedback REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5455?vs=13447=14158 BRANCH addNoteAboutGettextLocaleIssuse REVISION DETAIL

D5455: Extend Programmer's Guide with notes about influence of setlocale()

ilic added a comment. I guess not bad to mention this stuff, but I would make following adaptations: 1. Move the section as subsection of "Controlling Language Of Catalog to Use", and give it a more focused ( title, e.g. "Placing i18n calls before creation of QCoreApplication". 2.

D5455: Extend Programmer's Guide with notes about influence of setlocale()

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks a bit convoluted way of explaining not to use i18n before Q*Application, but i guess it works :) REPOSITORY R249 KI18n BRANCH addNoteAboutGettextLocaleIssuse REVISION DETAIL

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. ping? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5455 To: kossebau, #frameworks, ilic

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. Actually, I simplified/ignored how i18n calls internally make the gettext call chose a locale name for which a catalog has been found, by temporarily setting the LANGUAGE variable. What do you think, should this implementation detail be noted here as well, or

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. See thread around https://phabricator.kde.org/D5439#102005 for related discussion. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5455 To: kossebau, #frameworks, ilic

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Collect knowlegde found when investigating why i18n calls before line QApplication app; do not return translated strings. Perhaps needs more prominent place to warn about the issues.