This revision was automatically updated to reflect the committed changes.
Closed by commit R268:2c20ddff034e: KGlobalAccel: port to KKeyServer's new
method symXModXToKeyQt, to fix numpad… (authored by dfaure).
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
dfaure added a comment.
Ping? it seems like you are OK with this after all?
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D6234
To: dfaure, graesslin
Cc: #frameworks
dfaure added a comment.
I'm completely agree about being careful, as long as it's not the point of
not fixing bugs :-)
If you can think of more shortcuts that I should check, I'm happy to add them
to the unittest and test them with kglobalaccel.
REPOSITORY
R268 KGlobalAccel
REVISION
graesslin added a comment.
> Man it's demotivating to contribute to KDE. Users say all sorts of bad
things about KDE, and then future-ex-maintainers reject your contribution.
Great.
Yes sure, and you can imagine how many angry mails and bug reports I get when
things break. I made the
dfaure added a comment.
I don't use wayland, I use X11. I bet I'm not the only one. As long as that's
the case, fixing bugs in the X11 implementation makes a lot of sense.
Man it's demotivating to contribute to KDE. Users say all sorts of bad things
about KDE, and then
graesslin added a comment.
> I need to point out that this creates a functional difference to Wayland
and according to the latest rules of Plasma such changes are no longer allowed
unless the implementation is done first for Wayland.
After reading through KWin code together with your
graesslin added a comment.
I need to point out that this creates a functional difference to Wayland and
according to the latest rules of Plasma such changes are no longer allowed
unless the implementation is done first for Wayland.
Personally I am not really comfortable with such a
dfaure created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This commit requires KF 5.36.
BUG: 183458
TEST PLAN
the following global shortcuts were successfully tested:
Ctrl+1, Ctrl+Num+1, Ctrl+Num+/, Ctrl+F1, Ctrl+& (implicit shift)
REPOSITORY
