D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:76f66bab8841: Add support for proposed tags addition in 
OCS 1.7 (authored by leinir).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6512?vs=39175=40648

REVISION DETAIL
  https://phabricator.kde.org/D6512

AFFECTED FILES
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/parser.cpp

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra, ngraham
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, shipit!

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra, ngraham
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir requested review of this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 39175.
leinir added a comment.


  Address comments by cfeck
  Also mark new public API as @since 5.50

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6512?vs=16200=39175

REVISION DETAIL
  https://phabricator.kde.org/D6512

AFFECTED FILES
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/parser.cpp

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir marked 2 inline comments as done.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> content.cpp:338
> +
> +void Attica::Content::setTags(const QStringList& tags)
> +{

`& ` -> ` &`

> downloaddescription.cpp:306
> +
> +void Attica::DownloadDescription::setTags(const QStringList& tags)
> +{

again

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Arjen Hiemstra]

ahiemstra accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, 
bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck, 
sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Arjen Hiemstra]

ahiemstra added a comment.


  Right, so leave it to application users how to deal with that, maybe later on 
add some convenience functions. Sounds sensible. :)

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, 
bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck, 
sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D6512#296329 , @ahiemstra wrote:
  
  > T6133  suggests that tags are formatted 
as "group##key=value" or something similar. Wouldn't it make sense to handle 
parsing that format here as well? Or are tags more intended as exact matches?
  
  
  The group is more a convenience concept than anything else - i think it'd be 
nice to have something to do something with that, but not in this patch (the 
"something" needs a more proper definition, and i'd rather not have this 
functionality, which we need for the curating work that's being undertaken on 
the store, wait any longer than we have to...).
  
  To answer the specific question, during the matching phase the group##key is 
supposed to be considered canonical, and the groupings are more for pairing of 
similar content when putting things together. As a random sort of idea, one 
might imagine having something like a validator which matches the concept "must 
have something defined in group x", but that's why i've done the validators the 
way i have, there's nothing stopping us from putting that in when we have a 
purpose for the functionality :)

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, 
bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck, 
sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Arjen Hiemstra]

ahiemstra added a comment.


  T6133  suggests that tags are formatted as 
"group##key=value" or something similar. Wouldn't it make sense to handle 
parsing that format here as well? Or are tags more intended as exact matches?

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, 
bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck, 
sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Ping, if we could get this merged soon, it would be terribly handy :) (it's 
the basis for moderating the ghns content, and needed for the knewstuff patch 
in D6513 )

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: kde-frameworks-devel, #kde_store, michaelh, ZrenBot, ngraham, bruns, 
akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck, sebas, 
#frameworks

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In https://phabricator.kde.org/D6512#121834, @apol wrote:
  
  > +1 looks sensible to me.
  
  
  Sweet :)
  
  > What's the OCS state in this regard? When will 1.7 be a thing?
  
  OCS 1.7 will be a thing hopefully in the not too distant future... 
Incidentally, i need to regain write access to the fdo wiki, where said 
standard is hosted, as i lost that when they changed all the access methods 
in... some long time ago.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki, alexanderschmidt, 
siyuandong, ronaldv, mikesomov, starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Aleix Pol Gonzalez]

apol added a comment.


  +1 looks sensible to me.
  What's the OCS state in this regard? When will 1.7 be a thing?

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki, alexanderschmidt, 
siyuandong, ronaldv, mikesomov, starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir added a dependent revision: D6513: Add support for Attica tags support.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki, alexanderschmidt, 
siyuandong, ronaldv, mikesomov, starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a project: KDE Store.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This patch is to add support for the proposed addition of tags to the OCS 
standard version 1.7, as seen in https://phabricator.kde.org/T6133
  
  It is supposed to:
  
  - handle the addition of tags to content and download items
  - not fail if they are not available (just returning an empty list)

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

AFFECTED FILES
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/parser.cpp

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki, alexanderschmidt, 
siyuandong, ronaldv, mikesomov, starbuck, sebas