cullmann closed this revision.
cullmann added a comment.
Ok, then we just close this and wait for the next update.
Thanks for the work on that!
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #
turbov added a comment.
@cullmann,
Up to you... When I'll fix it for the cases I've found (trying to write the
`hightlighting.rst` test file) I come back w/ a new PR :)
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullm
cullmann added a comment.
Hmm, should we not commit this state at least as is?
Or do you want to do a new request including a new state & tests?
I would be fine with just pushing this as an intermediate step, too.
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #fra
turbov added a comment.
You can just close this MR, I'll be back sometime later w/ highlighting
example and tests...
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraha
turbov marked an inline comment as done.
turbov added a comment.
I'm using this syntax 'till nowadays from my repo... I know about some not
covered cases in it, but have no time these days to improve it even more %)
Most of the time I quite satisfied w/ it... and sorry for the tests :(
REVI
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Sorry for the delay. Shall we take care of this?
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann,
cullmann accepted this revision.
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns
cullmann added a comment.
If you are happy with the current state, I can add some auto-test for you and
push this.
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns
dhaumann added a comment.
@turbov ping again :-) After adding the reference file in autotest/input,
run make test, and then call ./autotests/update-reference-data.sh in your build
folder. Then git status will tell you which files are new and need to be added
updated.
REVISION DETAIL
http
cullmann added a comment.
Sorry, for the tests: inside the autotests, there is input/reference/html
Just add your testcase in input, run the tests, take a look at the results
and check them in as references.
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_
turbov added a comment.
In https://phabricator.kde.org/D7245#146719, @dhaumann wrote:
> @turbov ping
pong...
I wanted to make some improvements...
And it would be nice to have some hint about how to add the mentioned tests...
REVISION DETAIL
https://phabricator.kde.org/D7245
dhaumann added a comment.
@turbov ping
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, #frameworks
cullmann added a comment.
Hi, please add a testcase and we are done here.
Without a test case this can easily degenerate later again.
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, #frameworks
dhaumann added a comment.
Looks better, but still, could you provide an autotest case for unit testing,
licensed under MIT ?
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frameworks
turbov updated this revision to Diff 18321.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7245?vs=17993&id=18321
REVISION DETAIL
https://phabricator.kde.org/D7245
AFFECTED FILES
data/syntax/rest.xml
To: turbov, #kate, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frame
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
In general ok, but there are two issues to be fixed
1. Remove spaces around items as noted in the comment
2. Please extend / add a highlighting test case in autotest/inpu
turbov updated this revision to Diff 17993.
turbov added a comment.
Make code block `::` works as again as expected
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7245?vs=17992&id=17993
REVISION DETAIL
https://phabricator.kde.org/D7245
AFFECTED FILES
data/syntax/rest.xml
To: t
turbov updated this revision to Diff 17992.
turbov added a comment.
Fix attribute name
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7245?vs=17991&id=17992
REVISION DETAIL
https://phabricator.kde.org/D7245
AFFECTED FILES
data/syntax/rest.xml
To: turbov, #kate, #framework_synt
turbov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
1. make `code-block` directive looks like a "directive" and not like a "code"
2. highlight directive options for `code-block` (and `code`) -
19 matches
Mail list logo
