ngraham abandoned this revision.
ngraham added a subscriber: nicolasfella.
ngraham added a comment.
Herald added a subscriber: kde-frameworks-devel.
Doesn't make sense; @nicolasfella's new Places Panel section makes more sense
to put in once it's ready.
REPOSITORY
R241 KIO
REVISION DETAIL
ngraham added a comment.
https://phabricator.kde.org/D7700 is definitely better. My patch here was
just a quick-and-dirty way to get it quickly. We can close mine if that gets
committed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
To: ngraham, #frameworks, #do
alexeymin added a comment.
Maybe https://phabricator.kde.org/D7700 is better? We should choose one here,
I guess
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik,
elvisangelaccio, aacid,
ngraham added a reviewer: emmanuelp.
ngraham added a comment.
Any remaining objections?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik,
elvisangelaccio, aacid, emmanuelp
Cc: elvisangelac
ngraham edited the test plan for this revision.
ngraham added a reviewer: aacid.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik,
elvisangelaccio, aacid
Cc: elvisangelaccio, cfeck, navarromor
ngraham marked an inline comment as done.
ngraham added a comment.
The latest change should take care of that concern; I changed the `#ifdef`to
`if (KProtocolInfo::isKnownProtocol(QStringLiteral("tags")))`, which should
cover the case where Baloo was disabled after compilation but before Dolp
ltoscano added a comment.
In https://phabricator.kde.org/D7668#142505, @ngraham wrote:
> Oh good point, I forgot that this won't work if Baloo is disabled. I'll
guard it behind an #ifdef, which appears to be the standard way to do this,
looking through Dolphin's code.
>
> Since I'm p
ngraham updated this revision to Diff 19135.
ngraham added a comment.
Used a different mechanism for gating this code on Baloo being active.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7668?vs=19112&id=19135
REVISION DETAIL
https://phabricator.kde.org/D76
ngraham added a comment.
In https://phabricator.kde.org/D7668#142562, @elvisangelaccio wrote:
> Note that this only works if there are no custom places yet (probably not a
big deal).
Yes, the idea here is to change the default setting for new installs, and
this code is only run t
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
Note that this only works if there are no custom places yet (probably not a
big deal).
INLINE COMMENTS
> kfileplacesmodel.cpp:110
>
ngraham updated this revision to Diff 19112.
ngraham retitled this revision from "Add Tags browser places item to Dolphin
and file pickers by default" to "Add Tags browser places item to Dolphin and
file pickers by default if Baloo is enabled".
ngraham edited the summary of this revision.
REPOSI
ngraham added a comment.
Oh good point, I forgot that this won't work if Baloo is disabled. I'll guard
it behind an #ifdef, which appears to be the standard way to do this, looking
through Dolphin's code.
Since I'm proposing to change a default, the #ifdef will only avoid creating
the b
cfeck added a comment.
I tried entering "tags:/" in Dolphin, but got "Invalid protocol", most likely
because I have Baloo disabled. Either the error message needs to be more clear,
or the item should be hidden for disabled Baloo.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.k
ngraham added a comment.
This is similar to the change in https://phabricator.kde.org/D7446. These
hidden features are so powerful; we need to reveal them!
The one issue that I foresee with adding this is if a novice user clicks on
it before any tags have been created, they might be slig
ngraham created this revision.
ngraham added projects: Dolphin, Frameworks.
REVISION SUMMARY
BUG: 182367
Add a Tags places item (tags:/) to Dolphin and file pickers by default.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
AFFECTED FILES
src/filewidgets/kfil
15 matches
Mail list logo
