D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2018-02-15 Thread Milian Wolff
mwolff added a comment. In D7968#206500 , @whiting wrote: > Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2018-02-14 Thread Jeremy Whiting
whiting added a comment. Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-21 Thread Milian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a43aea3e: Forward QComboBox signals instead of QComboBox lineedit signals (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7968?vs=24188=24203#toc REPOSITORY R241

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-21 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kurlrequestertest.cpp:186 > +QTest::keyEvent(QTest::Click, req.comboBox(), Qt::Key_Down); > +qDebug() << textSpy << editSpy << returnSpy << returnWithTextSpy; > +QCOMPARE(textSpy.size(), 2); Please remove this line though.

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-21 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: #frameworks

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-20 Thread Milian Wolff
mwolff updated this revision to Diff 24188. mwolff added a comment. - expand test to non-editable combo box - fix wrong signal connection (regression introduced when ported to QOverload<>::of) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-08 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good, but aren't there unittests missing for the non-editable combo case? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol,

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-07 Thread Milian Wolff
mwolff added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: #frameworks

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-07 Thread Milian Wolff
mwolff updated this revision to Diff 23604. mwolff added a comment. use QOverload::of as suggested by apol REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7968?vs=23522=23604 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7968 AFFECTED FILES

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-05 Thread Milian Wolff
mwolff updated this revision to Diff 23522. mwolff retitled this revision from "WIP: Forward QComboBox signals instead of QComboBox lineedit signals" to "Forward QComboBox signals instead of QComboBox lineedit signals". mwolff edited the summary of this revision. mwolff removed subscribers: