This revision was automatically updated to reflect the committed changes.
Closed by commit R244:c688a15d871a: Improve apidox of KJobTrackerInterface
(authored by elvisangelaccio).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8336?vs=23725=23831
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau, dfaure
Cc: apol, #frameworks
elvisangelaccio updated this revision to Diff 23725.
elvisangelaccio added a comment.
- Dropped TODO, there is not enough evidence that this method should become
protected.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8336?vs=23105=23725
BRANCH
elvisangelaccio marked an inline comment as done.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau, dfaure
Cc: apol, #frameworks
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kjobtrackerinterface.h:88
> */
> -virtual void unregisterJob(KJob *job);
> +virtual void unregisterJob(KJob *job); // TODO KF6: should it become
elvisangelaccio updated this revision to Diff 23105.
elvisangelaccio marked 3 inline comments as done.
elvisangelaccio added a comment.
- Addressed comments
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8336?vs=20870=23105
BRANCH
master
REVISION
kossebau added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kjobtrackerinterface.h:73
> Probably yes, should we add a TODO comment for KF6?
And for the protected, not sure, it feels unbalanced to me. But something to
think about at time of KF6, so yes, add a (non-doxygen)
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
(Sorry, forgot about this one, subscribed too to many diffs in the
phabricator view)
Looks good to me in general. Added some comments you might want to consider,
but are free to
elvisangelaccio added a comment.
@kossebau Ping?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau, dfaure
Cc: apol, #frameworks
elvisangelaccio added inline comments.
INLINE COMMENTS
> apol wrote in kjobtrackerinterface.h:73
> Then it should be protected?
Probably yes, should we add a TODO comment for KF6?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau,
apol added inline comments.
INLINE COMMENTS
> kjobtrackerinterface.h:73
> * Unregister a job from this tracker.
> + * You need to manually call this method only if you re-implemented
> + * registerJob() without connecting KJob::finished to this slot.
Then it should be protected?
elvisangelaccio created this revision.
elvisangelaccio added reviewers: kossebau, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
As discussed in https://phabricator.kde.org/D3977, document when
unregisterJob()
12 matches
Mail list logo
