Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41043 --- This review has been submitted with commit 6801892e80324911ac9

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 30, 2013, 2:23 p.m.) Status -- This change has been ma

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Martin Klapetek
> On Sept. 30, 2013, 2:01 p.m., Aleix Pol Gonzalez wrote: > > staging/kprintutils/CMakeLists.txt, line 30 > > > > > > Why are you removing these? They have no effect on the code as the code compiles without them,

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41036 --- Ship it! Oh btw, it looks good to me and looks like an improve

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41027 --- staging/kprintutils/CMakeLists.txt

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41020 --- Ping - Martin Klapetek On Sept. 27, 2013, 9:15 a.m., Martin

Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- Review request for KDE Frameworks. Description --- ...before splittin