Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

On Nov. 9, 2013, 12:47 a.m., David Faure wrote: tier1/kcoreaddons/src/lib/CMakeLists.txt, line 128 http://git.reviewboard.kde.org/r/113723/diff/1/?file=212060#file212060line128 I think we should instead treat them as separate libs, and remove the inheritance from

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43411 --- I don't get the dependency of a dependency thing, surely once

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

On Nov. 11, 2013, 9:54 a.m., David Faure wrote: tier1/kcoreaddons/src/lib/jobs/kcompositejob_p.h, line 30 http://git.reviewboard.kde.org/r/113723/diff/2/?file=212461#file212461line30 Err why did you remove the inheritance from KJobPrivate, which is in the same library as

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- (Updated Nov. 11, 2013, 11:40 a.m.) Review request for KDE Frameworks.

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43421 --- Ship it! Ship It! - David Faure On Nov. 11, 2013, 11:40

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- (Updated Nov. 11, 2013, 2:15 p.m.) Status -- This change has been

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43433 --- This review has been submitted with commit

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

On Nov. 9, 2013, 12:47 a.m., David Faure wrote: staging/kio/CMakeLists.txt, line 34 http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line34 Why? KDED doesn't provide a library. Àlex Fiestas wrote: It provides a DBus interface (.xml) that is installed and

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- (Updated Nov. 11, 2013, 3:23 a.m.) Review request for KDE Frameworks.

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

On Nov. 9, 2013, 12:47 a.m., David Faure wrote: staging/kio/CMakeLists.txt, line 30 http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line30 already listed 6 lines above I had to add it because it's a dependency-of-a-dependency. I'll add a comment about that.

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

On Nov. 9, 2013, 12:47 a.m., David Faure wrote: staging/kio/CMakeLists.txt, line 34 http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line34 Why? KDED doesn't provide a library. It provides a DBus interface (.xml) that is installed and later on used in

Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43285 --- staging/kio/CMakeLists.txt