Re: Review Request 114038: Integrate KAboutData and QCommandLineParser

2013-11-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/ --- (Updated Nov. 25, 2013, 4:26 p.m.) Review request for KDE Frameworks.

Re: Review Request 114038: Integrate KAboutData and QCommandLineParser

2013-11-25 Thread Aleix Pol Gonzalez
On Nov. 24, 2013, 10:58 a.m., David Faure wrote: tier1/kcoreaddons/src/lib/kaboutdata.cpp, line 957 http://git.reviewboard.kde.org/r/114038/diff/1/?file=219248#file219248line957 (LOL, most likely someone forgot to call addAuthor, but OK :) Wrong usage of tr()

Re: Review Request 114038: Integrate KAboutData and QCommandLineParser

2013-11-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/#review44452 --- Ship it! Ship It! - David Faure On Nov. 25, 2013, 4:26

Review Request 114038: Integrate KAboutData and QCommandLineParser

2013-11-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/ --- Review request for KDE Frameworks. Repository: kdelibs Description