Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45465 --- tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-10 Thread Martin Klapetek
On Dec. 10, 2013, 3:37 p.m., Aleix Pol Gonzalez wrote: tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in, line 1 http://git.reviewboard.kde.org/r/114356/diff/3/?file=223532#file223532line1 Shouldn't that file be called KGlobalAccelConfig.cmake.in? We're not prefixing the

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45373 --- Imo this should be submitted renamed already, there's no

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 9, 2013, 3:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45390 --- Looking good as far as renaming goes, three small issues below

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 9, 2013, 4 p.m.) Review request for KDE Frameworks and

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- (Updated Dec. 10, 2013, 6:41 a.m.) Status -- This change has been

Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45449 --- This review has been submitted with commit

Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

2013-12-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: