Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/ --- Review request for KDE Frameworks and David Faure. Repository: kconfig

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/#review47143 --- src/kconfig_compiler/kconfig_compiler.cpp

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/ --- (Updated Jan. 10, 2014, 9:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/#review47144 --- What made me suggest this task was that --version was missing

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/ --- (Updated Jan. 10, 2014, 10:29 p.m.) Review request for KDE Frameworks

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/#review47176 --- Ship it! just two questions, feel free to commit after

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread Bhushan Shah
On Jan. 11, 2014, 5:03 a.m., David Faure wrote: src/kconfig_compiler/kconfig_compiler.cpp, line 1589 https://git.reviewboard.kde.org/r/114937/diff/3/?file=233674#file233674line1589 wrong indentation, or is this just reviewboard being buggy? there is proper indentation.. On Jan.

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/#review47181 --- This review has been submitted with commit

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

2014-01-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/ --- (Updated Jan. 11, 2014, 4:05 a.m.) Status -- This change has been