Re: Review Request 115030: Install public headers for KJsEmbed

2014-01-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/#review47503 --- src/kjsembed/CMakeLists.txt

Re: Review Request 115030: Install public headers for KJsEmbed

2014-01-16 Thread Alex Merry
On Jan. 16, 2014, 1:52 p.m., Alex Merry wrote: src/kjsembed/CMakeLists.txt, lines 38-39 https://git.reviewboard.kde.org/r/115030/diff/1/?file=234081#file234081line38 These don't look like public headers; are they really needed? Pointer isn't even namespaced. And

Re: Review Request 115030: Install public headers for KJsEmbed

2014-01-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/#review47516 --- Ship it! Still not ideal, but -- in the absence of an

Re: Review Request 115030: Install public headers for KJsEmbed

2014-01-16 Thread Aleix Pol Gonzalez
On Jan. 16, 2014, 3:48 p.m., Alex Merry wrote: Still not ideal, but -- in the absence of an enthusiastic maintainer -- that's unlikely to change any time soon. At least this makes it usable, and the names shouldn't clash. :) that's the spirit! Anyway, without installing headers, the

Re: Review Request 115030: Install public headers for KJsEmbed

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/#review47534 --- This review has been submitted with commit

Re: Review Request 115030: Install public headers for KJsEmbed

2014-01-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/ --- (Updated Jan. 16, 2014, 6:30 p.m.) Status -- This change has been

Review Request 115030: Install public headers for KJsEmbed

2014-01-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/ --- Review request for KDE Frameworks. Repository: kjsembed Description