---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/#review47503
---
src/kjsembed/CMakeLists.txt
On Jan. 16, 2014, 1:52 p.m., Alex Merry wrote:
src/kjsembed/CMakeLists.txt, lines 38-39
https://git.reviewboard.kde.org/r/115030/diff/1/?file=234081#file234081line38
These don't look like public headers; are they really needed?
Pointer isn't even namespaced. And
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/#review47516
---
Ship it!
Still not ideal, but -- in the absence of an
On Jan. 16, 2014, 3:48 p.m., Alex Merry wrote:
Still not ideal, but -- in the absence of an enthusiastic maintainer --
that's unlikely to change any time soon. At least this makes it usable,
and the names shouldn't clash.
:) that's the spirit!
Anyway, without installing headers, the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/#review47534
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/
---
(Updated Jan. 16, 2014, 6:30 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/
---
Review request for KDE Frameworks.
Repository: kjsembed
Description