Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/#review48259 --- This review has been submitted with commit

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/ --- (Updated Jan. 22, 2014, 9:21 a.m.) Review request for Build System,

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/#review48008 --- Ship it! Ship It! - Alex Merry On Jan. 22, 2014, 9:21

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-22 Thread Alex Merry
On Jan. 21, 2014, 11:02 p.m., Alex Merry wrote: modules/ECMGeneratePriFile.cmake, line 13 https://git.reviewboard.kde.org/r/115099/diff/1/?file=234571#file234571line13 I feel DEPS should really be a list, but CMake apparently doesn't have a join function, for some bizarre reason