Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Feb. 4, 2014, 12:26 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Changes --- Another FIXME (partially) cleared up. Repository: extra-cmake-modules Description --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs (updated) - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/#review48979 --- Ship it! Looks good to me - Alexander Richardson On Feb. 4, 2014, 1:26 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Feb. 4, 2014, 1:26 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/#review48985 --- This review has been submitted with commit 8feefd08de064de173fbfcef64a922087f9861fc by Alex Merry to branch master. - Commit Hook On Feb. 4, 2014, 12:26 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Feb. 4, 2014, 12:26 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Feb. 4, 2014, 10:55 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Feb. 4, 2014, 10:55 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/#review48986 --- This review has been submitted with commit b362f09095e7a5371d1a88378b0a847c92ba0057 by Alex Merry to branch master. - Commit Hook On Feb. 4, 2014, 12:26 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Feb. 4, 2014, 12:26 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/#review48880 --- kde-modules/KDECompilerSettings.cmake https://git.reviewboard.kde.org/r/115378/#comment34514 I think they are disabled by default, since I keep getting warnings that EHsc is missing whenever some STL headers are included. I think /EH- should disable exception handling if we don't want to rely on default behaviour (http://msdn.microsoft.com/en-us/library/1deeycx5.aspx) - Alexander Richardson On Jan. 29, 2014, 5:34 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Jan. 29, 2014, 5:34 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake 92d1f823f0b257a828b3acc98e77f386dd587ff2 Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/#review48547 --- Looks good, but I can't test it right now. kde-modules/KDECompilerSettings.cmake https://git.reviewboard.kde.org/r/115378/#comment34310 if(MSVC) is used everywhere else - Andrius da Costa Ribas On Jan. 29, 2014, 1:39 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Jan. 29, 2014, 1:39 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Jan. 29, 2014, 4:30 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Changes --- Added an extra commit that replaces compiler id checks against MSVC with checking the MSVC variable. Repository: extra-cmake-modules Description (updated) --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs (updated) - kde-modules/KDECompilerSettings.cmake 62ba4a0ab2cd2615fb54b3f938784b753bcff132 Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
