Re: Review Request 115613: Drop platform name from default user agent string
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. Martin Gräßlin wrote: ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application? Alexander Richardson wrote: Probably not very reliable, but maybe qEnvironmentVariableIsSet(DISPLAY)? Christoph Feck wrote: ... and risking a break when we switch to Wayland? If there are sites out there that need to see the X11 string, we should simply lie, and always send it for Linux. We aren't a Mozilla browser either... based on the discussion I opened a new review request which always forces to X11 if we are on unix-like systems: https://git.reviewboard.kde.org/r/115723/ - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- On Feb. 10, 2014, 10:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 10:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 13, 2014, 2:03 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Reviewboard is weird. I added that comment, but the mail sent by reviewboard doesn't show that anywhere. It makes it look like Martin made that change. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ---BeginMessage--- --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ---End Message--- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Mon, Feb 10, 2014 at 10:21 PM, David Faure fa...@kde.org wrote: On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Changes --- Adding more people for review. IMHO Dawit has final say on what the UA string should look like. Reviewboard is weird. I added that comment, but the mail sent by reviewboard doesn't show that anywhere. It makes it look like Martin made that change. Looks like Reviewboard doesn't track the person who makes changes to the metadata - so it assumes the author of the Review Request made it. Normally, this would be a valid assumption as only they have the permission to do so, unless someone has admin access (which you do). Guess you might want to file an issue with upstream. Thanks, Ben -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 -- Forwarded message -- From: Martin Gräßlin mgraess...@kde.org To: Dawit Alemayehu ada...@kde.org, Bernhard Beschow bbesc...@cs.tu-berlin.de Cc: KDE Frameworks kde-frameworks-devel@kde.org Date: Mon, 10 Feb 2014 09:15:23 + Subject: Re: Review Request 115613: Drop platform name from default user agent string This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. By Martin Gräßlin. *Updated Feb. 10, 2014, 9:15 a.m.* Changes Adding more people for review. IMHO Dawit has final say on what the UA string should look like. *Repository: * kio Description Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp (f81b6797887eebd868c36b98e867eb055b05a1e2) View Diff https://git.reviewboard.kde.org/r/115613/diff/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. - Dawit Alemayehu On Feb. 10, 2014, 9:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- On Feb. 10, 2014, 10:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 10:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. Martin Gräßlin wrote: ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application? Probably not very reliable, but maybe qEnvironmentVariableIsSet(DISPLAY)? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- On Feb. 10, 2014, 10:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 10:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115613: Drop platform name from default user agent string
On Feb. 10, 2014, 7:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string by default: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 And the latest Chromium (version 32) sends the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. Martin Gräßlin wrote: ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application? Alexander Richardson wrote: Probably not very reliable, but maybe qEnvironmentVariableIsSet(DISPLAY)? ... and risking a break when we switch to Wayland? If there are sites out there that need to see the X11 string, we should simply lie, and always send it for Linux. We aren't a Mozilla browser either... - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- On Feb. 10, 2014, 9:15 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115613: Drop platform name from default user agent string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- Review request for KDE Frameworks. Repository: kio Description --- Drop platform name from default user agent string The platform name (e.g. X11) was currently broken on compile time. On Linux it returned unknown and on all other platforms the same name as already included in the OS name. We cannot really determine the platform name as this is a core application and the Qt's platform name is only available in a GUI application. Compile time is no solution as we cannot know whether the binary is executed on X11, Wayland, Android or whatever. Diffs - src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 Diff: https://git.reviewboard.kde.org/r/115613/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
