Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115653/ --- (Updated Feb. 12, 2014, 7:29 a.m.) Status -- This change has been ma

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115653/#review49626 --- This review has been submitted with commit 807993b1bb506b1480

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115653/#review49622 --- Ship it! Ship It! - David Faure On Feb. 12, 2014, 7:12 a.m

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115653/ --- (Updated Feb. 12, 2014, 8:12 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Martin Gräßlin
> On Feb. 11, 2014, 11:53 a.m., Alex Merry wrote: > > Two (related) things concern me about this: > > > > You're putting stuff that references the particular Qt platform plugin name > > into desktop files, and you're doing it with something not prefixed with > > X-KDE- > > > > I'm not even su

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread David Faure
> On Feb. 11, 2014, 10:53 a.m., Alex Merry wrote: > > Two (related) things concern me about this: > > > > You're putting stuff that references the particular Qt platform plugin name > > into desktop files, and you're doing it with something not prefixed with > > X-KDE- > > > > I'm not even su

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Alex Merry
> On Feb. 11, 2014, 10:53 a.m., Alex Merry wrote: > > Two (related) things concern me about this: > > > > You're putting stuff that references the particular Qt platform plugin name > > into desktop files, and you're doing it with something not prefixed with > > X-KDE- > > > > I'm not even su

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Martin Gräßlin
> On Feb. 11, 2014, 11:53 a.m., Alex Merry wrote: > > Two (related) things concern me about this: > > > > You're putting stuff that references the particular Qt platform plugin name > > into desktop files, and you're doing it with something not prefixed with > > X-KDE- > > > > I'm not even su

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Alex Merry
> On Feb. 11, 2014, 10:53 a.m., Alex Merry wrote: > > Two (related) things concern me about this: > > > > You're putting stuff that references the particular Qt platform plugin name > > into desktop files, and you're doing it with something not prefixed with > > X-KDE- > > > > I'm not even su

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Martin Gräßlin
> On Feb. 11, 2014, 11:53 a.m., Alex Merry wrote: > > Two (related) things concern me about this: > > > > You're putting stuff that references the particular Qt platform plugin name > > into desktop files, and you're doing it with something not prefixed with > > X-KDE- > > > > I'm not even su

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Dominik Haumann
> On Feb. 11, 2014, 10:53 a.m., Alex Merry wrote: > > Two (related) things concern me about this: > > > > You're putting stuff that references the particular Qt platform plugin name > > into desktop files, and you're doing it with something not prefixed with > > X-KDE- > > > > I'm not even su

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115653/#review49530 --- Two (related) things concern me about this: You're putting st

Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115653/ --- Review request for KDE Frameworks. Repository: kservice Description ---