Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
On March 23, 2014, 11:39 p.m., Aleix Pol Gonzalez wrote: src/colors/kcolorutils.cpp, line 38 https://git.reviewboard.kde.org/r/116866/diff/5/?file=256190#file256190line38 Wouldn't it make more sense to use qIsNan? http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN Huh. Yes. Doing work on KJS had me in the wrong mindset :-) - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53877 --- On March 22, 2014, 8:54 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 8:54 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
On March 23, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote: src/colors/kcolorutils.cpp, line 38 https://git.reviewboard.kde.org/r/116866/diff/5/?file=256190#file256190line38 Wouldn't it make more sense to use qIsNan? http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN Alex Merry wrote: Huh. Yes. Doing work on KJS had me in the wrong mindset :-) D'oh, I should have thought of that . - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53877 --- On March 22, 2014, 1:54 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 1:54 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53877 --- src/colors/kcolorutils.cpp https://git.reviewboard.kde.org/r/116866/#comment37768 Wouldn't it make more sense to use qIsNan? http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN - Aleix Pol Gonzalez On March 22, 2014, 8:54 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 8:54 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53754 --- src/kguiaddons_config.h.cmake https://git.reviewboard.kde.org/r/116866/#comment37697 Technically, the (C) is a bit pointless. But it doesn't matter that much. src/kguiaddons_config.h.cmake https://git.reviewboard.kde.org/r/116866/#comment37698 This was also copied out of another file, right? - Alex Merry On March 21, 2014, 4:26 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 21, 2014, 4:26 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 10:13 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
On March 22, 2014, 6:29 a.m., Alex Merry wrote: src/kguiaddons_config.h.cmake, lines 20-21 https://git.reviewboard.kde.org/r/116866/diff/4/?file=255954#file255954line20 This was also copied out of another file, right? Nope, but it was put in before I changed my mind about the name of the file . - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53754 --- On March 22, 2014, 10:13 a.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 10:13 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53770 --- Ship it! Ship It! - Alex Merry On March 22, 2014, 5:13 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 5:13 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53772 --- This review has been submitted with commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c by Alex Merry on behalf of Michael Hansen to branch master. - Commit Hook On March 22, 2014, 5:13 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 5:13 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 8:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 21, 2014, 9:26 a.m.) Review request for KDE Frameworks. Changes --- Updated copyright Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53309 --- src/ConfigureChecks.cmake https://git.reviewboard.kde.org/r/116866/#comment37507 Either this line should be removed from here, or it should be added to kcolorutils.cpp (otherwise you're testing in one environment and using it in another). - Alex Merry On March 18, 2014, 3:18 a.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 3:18 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:25 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53347 --- Ship it! Ship It! - Alex Merry On March 18, 2014, 5:25 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 5:25 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53348 --- src/kguiaddons_config.h.cmake https://git.reviewboard.kde.org/r/116866/#comment37532 Do these copyright lines really apply to this new file? I think you should include just your own name (since you created this config file). - Nicolás Alvarez On March 18, 2014, 2:25 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 2:25 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
On March 18, 2014, 10:47 a.m., Nicolás Alvarez wrote: src/kguiaddons_config.h.cmake, line 2 https://git.reviewboard.kde.org/r/116866/diff/3/?file=255187#file255187line2 Do these copyright lines really apply to this new file? I think you should include just your own name (since you created this config file). Oops, I just copied that header from another .h file... - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53348 --- On March 18, 2014, 10:25 a.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:25 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:51 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53279 --- In general, I would prefer configure-time checks for the presence of these functions, rather than using Q_CC_ defines. See KJS for examples of these tests. - Alex Merry On March 17, 2014, 8:53 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 17, 2014, 8:53 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 17, 2014, 8:18 p.m.) Review request for KDE Frameworks. Changes --- Add a configuration file, and move isnan function detection to cmake Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
