On March 27, 2014, 9:31 p.m., Alex Merry wrote:
modules/ECMSetupQtTranslations.cmake, lines 81-83
https://git.reviewboard.kde.org/r/117052/diff/2/?file=257836#file257836line81
FindGettext calls the target pofiles. Is it worth making this target
qmfiles for consistency?
pofiles
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/
---
(Updated March 28, 2014, 10:45 a.m.)
Review request for Build System,
On March 27, 2014, 8:31 p.m., Alex Merry wrote:
modules/ECMSetupQtTranslations.cmake, lines 81-83
https://git.reviewboard.kde.org/r/117052/diff/2/?file=257836#file257836line81
FindGettext calls the target pofiles. Is it worth making this target
qmfiles for consistency?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/#review54424
---
modules/ECMSetupQtTranslations.cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/#review54446
---
Ship it!
Ship It!
- Alex Merry
On March 28, 2014, 1:46
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/
---
(Updated March 28, 2014, 3 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/
---
(Updated March 28, 2014, 2:46 p.m.)
Review request for Build System,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/#review54450
---
This review has been submitted with commit
On March 25, 2014, 3:33 p.m., Alex Merry wrote:
The docs need cleaning up, but I'd like to concentrate on the API first.
I'd rather this followed the convention of other file-generating macros in
getting the user to provide a variable name to store the file(s) in, rather
than
On March 25, 2014, 2:33 p.m., Alex Merry wrote:
The docs need cleaning up, but I'd like to concentrate on the API first.
I'd rather this followed the convention of other file-generating macros in
getting the user to provide a variable name to store the file(s) in, rather
than
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/
---
(Updated March 27, 2014, 4:26 p.m.)
Review request for Build System,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/#review54369
---
modules/ECMSetupQtTranslations.cmake
On March 27, 2014, 8:31 p.m., Alex Merry wrote:
modules/ECMTrLoader.cpp.in, line 19
https://git.reviewboard.kde.org/r/117052/diff/2/?file=257837#file257837line19
QLatin1String() when you're using +
Why? That doesn't make sense on my book.
- Aleix
On March 27, 2014, 8:31 p.m., Alex Merry wrote:
modules/ECMTrLoader.cpp.in, line 19
https://git.reviewboard.kde.org/r/117052/diff/2/?file=257837#file257837line19
QLatin1String() when you're using +
Aleix Pol Gonzalez wrote:
Why? That doesn't make sense on my book.
*Goes and
On March 25, 2014, 3:33 p.m., Alex Merry wrote:
The docs need cleaning up, but I'd like to concentrate on the API first.
I'd rather this followed the convention of other file-generating macros in
getting the user to provide a variable name to store the file(s) in, rather
than
On March 25, 2014, 2:33 p.m., Alex Merry wrote:
The docs need cleaning up, but I'd like to concentrate on the API first.
I'd rather this followed the convention of other file-generating macros in
getting the user to provide a variable name to store the file(s) in, rather
than
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/
---
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/#review54111
---
The docs need cleaning up, but I'd like to concentrate on the
18 matches
Mail list logo
