Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

2014-03-26 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/ --- Review request for KDE Frameworks. Repository: kservice Description

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

2014-03-26 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/ --- (Updated March 26, 2014, 5:05 p.m.) Review request for KDE Frameworks.

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

2014-03-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/#review54215 --- Ship it! I think it makes sense, it's not linking with

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

2014-03-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/#review54216 --- This review has been submitted with commit

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

2014-03-26 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/ --- (Updated March 26, 2014, 4:28 p.m.) Status -- This change has been