Re: Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56423 --- Ship it! Ship It! - Kevin Ottens On April 11, 2014, 8:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 11, 2014, 8:32 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KIdleTime successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56424 --- This review has been submitted with commit a92b1da58ea317a3a6d2e9c0d68fbf1b77518717 by Alex Merry to branch master. - Commit Hook On April 11, 2014, 8:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 11, 2014, 8:32 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KIdleTime successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 11, 2014, 8:28 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Changes --- Update to new documentation format. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs (updated) - find-modules/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KWindowSystem successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 11, 2014, 8:32 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Changes --- KIdleTime is the only thing that uses this. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing (updated) --- Configured and build KIdleTime successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
On April 11, 2014, 5:32 a.m., Martin Gräßlin wrote: I'm wondering whether it's still needed in kwindowsystem at all. So the test might not be telling much. Martin Gräßlin wrote: my task to remove the dependency from kwindowsystem failed: it's already no longer used. I'm just wondering where we have code which still uses this X11_XCB, it might be possible to delete it. It's in fact only needed for Qt4 as with Qt5 one gets the xcb_connection_t* through QX11Info. KIdleTime still uses it. LXR suggests it's the only user. I'd be for removing it if the beta version hadn't already been released. While not technically part of frameworks, I think ECM should still stick with the SC after beta thing. In this case, I'm not too bothered about leaving it in. It provides a sort of completeness with FindXCB and CMake's FindX11. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review55425 --- On April 11, 2014, 8:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 11, 2014, 8:32 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KIdleTime successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake e2c18a99873dc6db572c9761e5b15bddc3505fea Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KWindowSystem successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review55425 --- I'm wondering whether it's still needed in kwindowsystem at all. So the test might not be telling much. - Martin Gräßlin On April 10, 2014, 8:40 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 10, 2014, 8:40 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake e2c18a99873dc6db572c9761e5b15bddc3505fea Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KWindowSystem successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
On April 11, 2014, 7:32 a.m., Martin Gräßlin wrote: I'm wondering whether it's still needed in kwindowsystem at all. So the test might not be telling much. my task to remove the dependency from kwindowsystem failed: it's already no longer used. I'm just wondering where we have code which still uses this X11_XCB, it might be possible to delete it. It's in fact only needed for Qt4 as with Qt5 one gets the xcb_connection_t* through QX11Info. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review55425 --- On April 10, 2014, 8:40 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 10, 2014, 8:40 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake e2c18a99873dc6db572c9761e5b15bddc3505fea Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KWindowSystem successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
