Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 23, 2014, 9:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56327 --- This review has been submitted with commit b87a8701c3243bfb957d4dcaed60dbbbd177ea8e by David Jarvie to branch master. - Commit Hook On April 22, 2014, 10:03 p.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 22, 2014, 10:03 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 22, 2014, 10:03 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Fixed warning text. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs (updated) - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56243 --- Ship it! Ship It! - David Faure On April 22, 2014, 10:03 p.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 22, 2014, 10:03 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56124 --- src/plugin/kdbusservicestarter.cpp https://git.reviewboard.kde.org/r/117604/#comment39148 A serviceType isn't a service. This should say Couldn't start service dbusService for serviceType : err; - David Faure On April 20, 2014, 10:22 a.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 20, 2014, 10:22 a.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review55921 --- src/plugin/kdbusservicestarter.cpp https://git.reviewboard.kde.org/r/117604/#comment38944 It should be a qWarning. Looks good to me though, it's very annoying to debug this kind of problems without feedback. +1 - Aleix Pol Gonzalez On April 16, 2014, 9:07 p.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 16, 2014, 9:07 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
