Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-06-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/ --- (Updated June 2, 2014, 11:44 a.m.) Status -- This change has been

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review58955 --- This review has been submitted with commit

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review58849 --- Ship it! Ship It! - David Faure On May 29, 2014, 5 p.m.,

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-29 Thread Alex Merry
On May 14, 2014, 2:24 p.m., David Faure wrote: It is correct that this is about a string representation of the filesize, to displaying in a column of the model. For machine processing one can use KFileItem::size() after getting the KFileItem out of the KDirModel. However, do we

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/ --- (Updated May 29, 2014, 7 p.m.) Review request for KDE Frameworks and

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review58752 --- hehehe, that's quite a change. This will keep sorting happy.

Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review57921 --- Ehh.. Does this mean that there is no way to get the actual

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Martin Klapetek
On May 14, 2014, 4:13 p.m., Mark Gaiser wrote: Ehh.. Does this mean that there is no way to get the actual byte size anymore? In that case i think it would be better to introduce a new role: HumanReadableSize which does what your patch is doing now. Note: i really think that

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review57923 --- It is correct that this is about a string representation of

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Mark Gaiser
On May 14, 2014, 2:13 p.m., Mark Gaiser wrote: Ehh.. Does this mean that there is no way to get the actual byte size anymore? In that case i think it would be better to introduce a new role: HumanReadableSize which does what your patch is doing now. Note: i really think that

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Frank Reininghaus
On May 14, 2014, 2:24 p.m., David Faure wrote: It is correct that this is about a string representation of the filesize, to displaying in a column of the model. For machine processing one can use KFileItem::size() after getting the KFileItem out of the KDirModel. However, do we

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Martin Klapetek
On May 14, 2014, 4:24 p.m., David Faure wrote: It is correct that this is about a string representation of the filesize, to displaying in a column of the model. For machine processing one can use KFileItem::size() after getting the KFileItem out of the KDirModel. However, do we

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread David Faure
On May 14, 2014, 2:24 p.m., David Faure wrote: It is correct that this is about a string representation of the filesize, to displaying in a column of the model. For machine processing one can use KFileItem::size() after getting the KFileItem out of the KDirModel. However, do we

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread David Faure
On May 14, 2014, 2:24 p.m., David Faure wrote: It is correct that this is about a string representation of the filesize, to displaying in a column of the model. For machine processing one can use KFileItem::size() after getting the KFileItem out of the KDirModel. However, do we

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Martin Klapetek
On May 14, 2014, 4:24 p.m., David Faure wrote: It is correct that this is about a string representation of the filesize, to displaying in a column of the model. For machine processing one can use KFileItem::size() after getting the KFileItem out of the KDirModel. However, do we