Re: Review Request 119388: Add KDE Frameworks 5 simple app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- (Updated July 28, 2014, 2:41 p.m.) Status -- This change has been ma

Re: Review Request 119388: Add KDE Frameworks 5 simple app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- (Updated July 22, 2014, 4:26 p.m.) Review request for KDE Frameworks, Ann

Re: Review Request 119388: Add KDE Frameworks 5 simple app

On July 21, 2014, 4:24 p.m., Jonathan Riddell wrote: > > Also is it really worth having icons? I guess it's fine, but maybe it could > > be skipped. icons are nice :) - Jonathan --- This is an automatically generated e-mail. To reply,

Re: Review Request 119388: Add KDE Frameworks 5 simple app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- (Updated July 22, 2014, 9:12 a.m.) Review request for KDE Frameworks and

Re: Review Request 119388: Add KDE Frameworks 5 simple app

> On juil. 22, 2014, 7:42 matin, Laurent Montel wrote: > > templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 > > > > > > bool KAboutData::setupCommandLine(QCommandLineParser *parser) > > { > >

Re: Review Request 119388: Add KDE Frameworks 5 simple app

> On July 22, 2014, 7:42 a.m., Laurent Montel wrote: > > templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 > > > > > > bool KAboutData::setupCommandLine(QCommandLineParser *parser) > > { > > i

Re: Review Request 119388: Add KDE Frameworks 5 simple app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/#review62848 --- templates/C++/kde-frameworks5-simple/src/main.cpp

Re: Review Request 119388: Add KDE Frameworks 5 simple app

> On July 21, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: > > templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 > > > > > > No need to do addHelpOption and addVersionOption, they're added by > > setupComm

Re: Review Request 119388: Add KDE Frameworks 5 simple app

> On July 21, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: > > templates/C++/kde-frameworks5-simple/CMakeLists.txt, line 20 > > > > > > The application you're creating doesn't need XmlGui, I think it's fine > > if

Re: Review Request 119388: Add KDE Frameworks 5 simple app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/#review62803 --- templates/C++/kde-frameworks5-simple/CMakeLists.txt

Review Request 119388: Add KDE Frameworks 5 simple app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- Review request for KDE Frameworks and Anne-Marie Mahfouf. Repository: kap