Re: Review Request 120605: cleanup overlay icon usage

2014-11-10 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/ --- (Updated Nov. 11, 2014, midnight) Status -- This change has been mar

Re: Review Request 120605: cleanup overlay icon usage

2014-11-10 Thread David Faure
> On Nov. 1, 2014, 12:38 p.m., Emmanuel Pescosta wrote: > > Ping? No git account? > > Albert Astals Cid wrote: > He does have an account as you can see in > http://websvn.kde.org/trunk/kde-common/accounts?view=markup > > But you can still commit it yourself, don't forget to use --a

Re: Review Request 120605: cleanup overlay icon usage

2014-11-01 Thread Stefan Brüns
> On Nov. 1, 2014, 12:38 p.m., Emmanuel Pescosta wrote: > > Ping? No git account? > > Albert Astals Cid wrote: > He does have an account as you can see in > http://websvn.kde.org/trunk/kde-common/accounts?view=markup > > But you can still commit it yourself, don't forget to use --a

Re: Review Request 120605: cleanup overlay icon usage

2014-11-01 Thread Albert Astals Cid
> On nov. 1, 2014, 12:38 p.m., Emmanuel Pescosta wrote: > > Ping? No git account? He does have an account as you can see in http://websvn.kde.org/trunk/kde-common/accounts?view=markup But you can still commit it yourself, don't forget to use --author in the git commit line and that's it :)

Re: Review Request 120605: cleanup overlay icon usage

2014-11-01 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review69638 --- Ping? No git account? - Emmanuel Pescosta On Oct. 16, 2014,

Re: Review Request 120605: cleanup overlay icon usage

2014-10-19 Thread David Faure
> On Oct. 19, 2014, 10:34 p.m., David Faure wrote: > > I think the idea of the .gz overlay was for more specific files like > > foo.txt.gz, postscript.ppd.gz, appdata.xml.gz > > > > But indeed meanwhile many others of these got their own mimetype (*.pcf.gz > > is application/x-font-pcf, *.pdf.

Re: Review Request 120605: cleanup overlay icon usage

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review68731 --- Ship it! I think the idea of the .gz overlay was for more spe

Re: Review Request 120605: cleanup overlay icon usage

2014-10-19 Thread Emmanuel Pescosta
> On Oct. 16, 2014, 8:09 p.m., Emmanuel Pescosta wrote: > > Looks good! +1 from my side > > > > (Please use the CCBUG hook when you commit this patch, because it only > > fixes one mentioned problem) > > Stefan Brüns wrote: > Any more comments? Is this a SHIP IT? > > BTW: The same

Re: Review Request 120605: cleanup overlay icon usage

2014-10-18 Thread Stefan Brüns
> On Oct. 16, 2014, 6:09 p.m., Emmanuel Pescosta wrote: > > Looks good! +1 from my side > > > > (Please use the CCBUG hook when you commit this patch, because it only > > fixes one mentioned problem) Any more comments? Is this a SHIP IT? BTW: The same applies to SC 4, should I backport it to

Re: Review Request 120605: cleanup overlay icon usage

2014-10-16 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review68567 --- Looks good! +1 from my side (Please use the CCBUG hook when y

Review Request 120605: cleanup overlay icon usage

2014-10-16 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/ --- Review request for KDE Frameworks. Bugs: 339193 https://bugs.kde.org/