Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 29, 2014, 4:22 p.m.) Status -- This change has been ma

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 28, 2014, 1:37 p.m.) Status -- This change has been ma

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69260 --- Ship it! Just one last thing, then push. src/widgets/krun.c

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 28, 2014, 5:13 p.m.) Review request for KDE Frameworks. R

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 28, 2014, 3:35 p.m., David Faure wrote: > > src/widgets/executablefileopendialog.cpp, line 64 > > > > > > where is this slot used? Nowhere. The file was copy-pasted from the other patch - Arjun

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 28, 2014, 10:05 a.m., David Faure wrote: > > src/widgets/krun.cpp, line 978 > > > > > > This should use the 4 args connect, in case the KRun gets deleted > > before the dialog. > > > > i.e. in

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 28, 2014, 3:35 p.m., David Faure wrote: > > src/widgets/krun.cpp, line 978 > > > > > > This should use the 4 args connect, in case the KRun gets deleted > > before the dialog. > > > > i.e. ins

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69246 --- src/widgets/executablefileopendialog.cpp

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 28, 2014, 1:20 p.m.) Review request for KDE Frameworks. R

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 11:43 a.m., David Faure wrote: > > Thanks for the patch. > > > > Calling init() again surprised me a bit, since this method was never called > > twice before, but OK, anything else would be much more invasive. I would > > suggest to at least add a comment e.g. in the call t

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 1:14 p.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code pa

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 11:14 a.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code p

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 1:14 p.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code pa

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Okt. 23, 2014, 11:14 vorm., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 4:44 p.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code pa

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review68990 --- src/widgets/krun.cpp

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review68987 --- src/widgets/executablefileopendialog.h

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review68968 --- Thanks for the patch. Calling init() again surprised me a bit

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 22, 2014, 9:40 p.m.) Review request for KDE Frameworks. R

Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- Review request for KDE Frameworks. Repository: kio Description ---