Re: Review Request 122893: Populate KIconDialog on showEvent

2015-07-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated Juli 3, 2015, 9:16 nachm.) Status -- This change has been

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-14 Thread Kai Uwe Broulik
On März 13, 2015, 10:25 vorm., Christoph Feck wrote: Hopefully I did not miss anything this time :) Done - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77409

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 13, 2015, 6:36 vorm.) Review request for KDE Frameworks.

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77409 --- Ship it! Hopefully I did not miss anything this time :) -

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:57 p.m.) Status -- This change has been

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 12, 2015, 7:10 nachm.) Review request for KDE Frameworks.

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77394 --- Ship it! Ship It! - Christoph Feck On March 12, 2015,

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Christoph Feck
On March 12, 2015, 7:15 p.m., Christoph Feck wrote: Ship It! Thinking again, the way you use the eventFilter (for the KIconDialog object), it still will not work with derived classes not recompiled. You need to create a separate (child) object which has the eventFilter method, and watch

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 11, 2015, 10:56 nachm.) Review request for KDE Frameworks.

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77320 --- src/kicondialog.cpp

Review Request 122893: Populate KIconDialog on showEvent

2015-03-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- Review request for KDE Frameworks. Repository: kiconthemes Description

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-10 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77276 --- I don't know whether this is binary compatible. It is not.