Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 7:45 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 962 > > > > > > That's not what this is for. It's so it uses merely the "shape" of the > > icon. From your description

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 30, 2016, 12:39 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 30, 2016, 10:43 a.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 910 > > > > > > That "bell" looks like some electrical circuit symbol, I'd rather > > prefer the exclamation mark

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review96017 --- src/kstatusnotifieritem.cpp (line 903)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 29, 2016, 8:03 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 7:45 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 962 > > > > > > That's not what this is for. It's so it uses merely the "shape" of the > > icon. From your description

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review95996 --- src/kstatusnotifieritem.cpp (line 955)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 29, 2016, 7:30 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > > > Kai Uwe Broulik wrote: > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are > monochrome usually. > > René J.V. Bertin wrote: > Most of Apple's own icons in the menubar have always been monochrome. >

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > > > Kai Uwe Broulik wrote: > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are > monochrome usually. > > René J.V. Bertin wrote: > Most of Apple's own icons in the menubar have always been monochrome.

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > > > Kai Uwe Broulik wrote: > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are > monochrome usually. Most of Apple's own icons in the menubar have always been monochrome. This is not true for 3rd party

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are monochrome usually. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review95984 --- src/kstatusnotifieritem.cpp (line 902)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 29, 2016, 5:41 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:27 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > I really think this should be handled/mapped > > by the OS X native systray thing. But I guess > >

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:07 p.m., Martin Klapetek wrote: > > > is it to be expected (in kstatusnotifieritemtest.cpp) that > > > tray->iconPixmap() returns a null QIcon immediately after calling > > > tray->setIconByName() > > > > I believe so, it's "either-or", either you set the icon by name

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 19, 2015, 10:56 a.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:27 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, lines 279-281 > > > > > > This has a strange indentation > > > > Also I think those bools are not entirely useful,

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89725 --- src/kstatusnotifieritem.cpp (lines 279 - 281)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89724 --- > is it to be expected (in kstatusnotifieritemtest.cpp) that

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89652 --- Well, it isn't exactly easy, but I remembered that KMail can

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 3 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 5:26 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 12:40 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 16, 2015, 5:40 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 710 > > > > > > Why is it reasonable if the platform guidelines speak against it? > > René J.V. Bertin wrote: >

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 16, 2015, 10:24 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 16, 2015, 5:40 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 710 > > > > > > Why is it reasonable if the platform guidelines speak against it? The platform guidelines apply to

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89603 --- Looks fine to me, but I'll let Martin decide, since he

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89608 --- Can you please add a screenshot of how such menu looks like