> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
> On Jan. 14, 2016, 12:35 p.m., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/
---
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Repository:
> On Jan. 14, 2016, 1:03 p.m., Sergio Martins wrote:
> > Ship It!
Can you push it in two different commits ? One for the QStringLiteral change
and another for the isEmpty()
- Sergio
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/#review91076
---
Ship it!
Ship It!
- Sergio Martins
On Jan. 14, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/#review91067
---
Looks good, I'll add Sergio, he maybe can explain what the
> On Jan. 14, 2016, 1:03 p.m., Sergio Martins wrote:
> > Ship It!
>
> Sergio Martins wrote:
> Can you push it in two different commits ? One for the QStringLiteral
> change and another for the isEmpty()
Regarding the qDeleteAll(), the correct way is
> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
> On Jan. 14, 2016, 1:35 p.m., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
> On Jan. 14, 2016, 2:03 p.m., Sergio Martins wrote:
> > Ship It!
>
> Sergio Martins wrote:
> Can you push it in two different commits ? One for the QStringLiteral
> change and another for the isEmpty()
>
> Sergio Martins wrote:
> Regarding the qDeleteAll(), the correct way is
>
> On Янв. 14, 2016, 1:03 п.п., Sergio Martins wrote:
> > Ship It!
>
> Sergio Martins wrote:
> Can you push it in two different commits ? One for the QStringLiteral
> change and another for the isEmpty()
>
> Sergio Martins wrote:
> Regarding the qDeleteAll(), the correct way is
>
> On Jan. 14, 2016, 12:35 p.m., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/
---
(Updated Jan. 14, 2016, 11:21 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/
---
(Updated Янв. 14, 2016, 10:40 п.п.)
Review request for KDE Frameworks,
> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
> On Jan. 14, 2016, 12:35 p.m., Aleix Pol Gonzalez wrote:
> > Looks good, I'll add Sergio, he maybe can explain what the warning meant in
> > the first place.
> >
> > Andrey, Are you sure you fixed all the warnings? I found some missing, for
> > example:
> >
19 matches
Mail list logo
