Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-15 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- (Updated March 15, 2016, 8:53 p.m.) Status -- This change has been

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-08 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- (Updated März 8, 2016, 7:47 nachm.) Review request for KDE Frameworks,

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-08 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review93290 --- Fix it, then Ship it! Looks good

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-02 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- (Updated März 2, 2016, 8:18 nachm.) Review request for KDE Frameworks,

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-02 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review93073 --- Looks good to me. I'd prefer inline noop functions to

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review93050 --- Ship it! Nothing should change when we're not on Android.

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-01 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- (Updated März 1, 2016, 9:38 nachm.) Review request for KDE Frameworks,

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-01 Thread Alex Richardson
> On March 1, 2016, 12:26 a.m., Aleix Pol Gonzalez wrote: > > src/lib/CMakeLists.txt, line 116 > > > > > > Why does pthread make a difference? > > Andreas Cord-Landwehr wrote: > Bionic provides native

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-02-29 Thread Andreas Cord-Landwehr
> On März 1, 2016, 12:26 vorm., Aleix Pol Gonzalez wrote: > > src/lib/CMakeLists.txt, line 116 > > > > > > Why does pthread make a difference? Bionic provides native built-in support for (limited set of)

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-02-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review92959 --- src/lib/CMakeLists.txt (line 114)

Review Request 127205: Add stubs to allow compilation on Android.

2016-02-28 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson.