Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-28 Thread Elvis Angelaccio 


> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
> Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from 
> KF5 and KButtonGroup from kdelibs4support at the same time..
> 
> Anthony Fieroni wrote:
> Maybe you should keep all deprecated classes hardcoded.
> 
> Elvis Angelaccio wrote:
> Yeah.
> @Albert: it's ok for you if I only remove the kdelibs3 class names? If 
> you want I can also split this patch in 2 commits (one for the QMetaObject 
> conversion and another one for the kdelibs3 cleanup).
> 
> Albert Astals Cid wrote:
> having two patches is a much easier way to be able to review them i'd say.

After thinking more about this, I'm going to drop the QMetaObject conversion. 
If these classes ever get deprecated and put in a "kf5support" lib, the kf6 
version of KConfigDialogManager will have to revert back to the hardcoded 
strings anyway...

tl;dr
I'll just drop the kdelibs3 classes


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-28 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/
---

(Updated Dec. 28, 2016, 11:05 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
---

The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
old class names (even from kdelibs3 times!). This patch replaces most of the 
hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
checks and that we don't use non-kf5 classes. We keep the hardcoded names only 
for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, KIO).


Diffs
-

  src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
  src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 

Diff: https://git.reviewboard.kde.org/r/129658/diff/


Testing
---

Builds, tests pass.


Thanks,

Elvis Angelaccio

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101623
---




src/kconfigdialogmanager.cpp 


Please keep the ones that stayed in KDELibs4Support...


- Aleix Pol Gonzalez


On Dec. 16, 2016, 4:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Albert Astals Cid 


> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
> Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from 
> KF5 and KButtonGroup from kdelibs4support at the same time..
> 
> Anthony Fieroni wrote:
> Maybe you should keep all deprecated classes hardcoded.
> 
> Elvis Angelaccio wrote:
> Yeah.
> @Albert: it's ok for you if I only remove the kdelibs3 class names? If 
> you want I can also split this patch in 2 commits (one for the QMetaObject 
> conversion and another one for the kdelibs3 cleanup).

having two patches is a much easier way to be able to review them i'd say.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio 


> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
> Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from 
> KF5 and KButtonGroup from kdelibs4support at the same time..
> 
> Anthony Fieroni wrote:
> Maybe you should keep all deprecated classes hardcoded.

Yeah.
@Albert: it's ok for you if I only remove the kdelibs3 class names? If you want 
I can also split this patch in 2 commits (one for the QMetaObject conversion 
and another one for the kdelibs3 cleanup).


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Anthony Fieroni 


> On Дек. 27, 2016, 11:16 след обяд, Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
> Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from 
> KF5 and KButtonGroup from kdelibs4support at the same time..

Maybe you should keep all deprecated classes hardcoded.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Дек. 16, 2016, 5:05 след обяд, Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Дек. 16, 2016, 5:05 след обяд)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio 


> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html

Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from KF5 
and KButtonGroup from kdelibs4support at the same time..


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio 


> On Dec. 27, 2016, 9:18 p.m., Christoph Feck wrote:
> > className() is just a char pointer. Is it possible to convert the maps to 
> > not use QString?

I don't think so, they are public api, e.g. `static QHash 
*changedMap();`


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101612
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio 


> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.

Why? Isn't it deprecated? 
https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Christoph Feck 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101612
---



className() is just a char pointer. Is it possible to convert the maps to not 
use QString?

- Christoph Feck


On Dec. 16, 2016, 4:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---



-1 Don't break what is not broken.

First thing i check "KButtonGroup", is already wrong to be removed.

- Albert Astals Cid


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101606
---



Ping?

- Elvis Angelaccio


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-16 Thread Elvis Angelaccio 


> On Dec. 16, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote:
> > +1
> > Would it be possible to do the same with the signals?

Unfortunately that would break compatibility (the maps are public and clients 
can insert new stuff there)


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101471
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-16 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101471
---



+1
Would it be possible to do the same with the signals?

- Aleix Pol Gonzalez


On Dec. 16, 2016, 4:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-16 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/
---

Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
---

The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
old class names (even from kdelibs3 times!). This patch replaces most of the 
hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
checks and that we don't use non-kf5 classes. We keep the hardcoded names only 
for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, KIO).


Diffs
-

  src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
  src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 

Diff: https://git.reviewboard.kde.org/r/129658/diff/


Testing
---

Builds, tests pass.


Thanks,

Elvis Angelaccio