Re: Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129723/
---

(Updated Jan. 2, 2017, 10:46 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 6fcc3bc6762f32cb152ea69ffdad3147c686a927 by Albert Astals 
Cid to branch master.


Repository: kparts


Description
---

What summary says


Diffs
-

  src/mainwindow.cpp b335598 

Diff: https://git.reviewboard.kde.org/r/129723/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

2017-01-02 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129723/#review101718
---


Ship it!




This is going to be called multiple times in apps with parts and plugins, but I 
guess that's OK, the developer will fix the bug and the user will check the 
checkbox.

- David Faure


On Jan. 2, 2017, 10:34 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129723/
> ---
> 
> (Updated Jan. 2, 2017, 10:34 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kparts
> 
> 
> Description
> ---
> 
> What summary says
> 
> 
> Diffs
> -
> 
>   src/mainwindow.cpp b335598 
> 
> Diff: https://git.reviewboard.kde.org/r/129723/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

2016-12-29 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129723/
---

Review request for KDE Frameworks.


Repository: kparts


Description
---

What summary says


Diffs
-

  src/mainwindow.cpp b335598 

Diff: https://git.reviewboard.kde.org/r/129723/diff/


Testing
---


Thanks,

Albert Astals Cid