Re: setting default widgetStyle (and ColorScheme)

2016-03-24 Thread Martin Graesslin
On Saturday, November 28, 2015 7:58:47 PM CET René J. V. Bertin wrote: > Olivier Goffart wrote: > > A pure KF5 appliation would anyway use the KDE platform theme plugin > > provided by KDE Frameworks. (in frameworkintegration) > > (So in other words: that code should not be executed when kde

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread René J . V . Bertin
Martin Graesslin wrote: > That is in deed a better approach. I'm still questioning whether it's the > right thing to do on OSX, but that would then be up to the OSX developers to > decide on. I'll handle that tomorrow. > But if the platformtheme plugin does get moved to Plasma I would say

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread René J . V . Bertin
Martin Graesslin wrote: > In my opinion: no. I even think the frameworkintegration framework should get > removed from frameworks and moved into Plasma Workspace. Because that's what > it is about: integrating Qt applications into plasma. I don't care where the framework is, but I do think

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread Martin Graesslin
On Monday, November 30, 2015 11:06:57 AM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > In my opinion: no. I even think the frameworkintegration framework should > > get removed from frameworks and moved into Plasma Workspace. Because > > that's what it is about: integrating Qt

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread René J . V . Bertin
René J. V. Bertin wrote: > Of course one could work on improving the native theme, but wouldn't that be > easiest by writing a dedicated KDE theme? In fact, I ought to check what > happens if one selects the "Macintosh (aqua)" style as KDE's widget style and > then applies the font selection from

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread René J . V . Bertin
Martin Graesslin wrote: Is this going to turn into another shouting match? > That's not the point! Any user can use whatever theme they want. The question > is whether we should default to our Plasma defaults on non-Plasma. And the > question to that can only be: NO! I'm not suggesting it

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread Martin Graesslin
On Monday, November 30, 2015 1:17:20 PM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > Is this going to turn into another shouting match? sorry what? > > > That's not the point! Any user can use whatever theme they want. The > > question is whether we should default to our Plasma

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread Martin Graesslin
On Monday, November 30, 2015 3:01:40 PM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > what you put on review board is in my opinion not a minimal modification. > > That are lots of ifdefs and each ifdef is a huge burden for the > > framework. It means > ... > > > Given that: we need

Re: setting default widgetStyle (and ColorScheme)

2015-11-29 Thread Martin Graesslin
On Saturday, November 28, 2015 7:58:47 PM CET René J. V. Bertin wrote: > Olivier Goffart wrote: > > A pure KF5 appliation would anyway use the KDE platform theme plugin > > provided by KDE Frameworks. (in frameworkintegration) > > (So in other words: that code should not be executed when kde

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-28 Thread René J . V . Bertin
Aleix Pol wrote: >> In fact, my observations probably imply that the code *is* called when >> running "pure Qt5" apps under X11 (it is with the xcb plugin on OS X; I >> checked). If indeed so, I think it should be updated to comply with KF5 >> principles if KDE_SESSION_VERSION = 5 (and use the

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-28 Thread Kai Uwe Broulik
Hi, > A priori users should then still be able to use Qt's native Macintosh "aqua" theme by selecting it as their KDE widget style. I think it should do that automatically anyway. I wouldn't want to install System Settings to begin with, let alone manually choosing the platform-native look.

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-28 Thread René J . V . Bertin
btw, I'm also fine with having to set, say, KDE_SESSION_VERSION to a meaningful value in order to get automatic loading of the selected KDE theme, at least as long as it's possible to set env. variables session-wide on OS X. R. ___

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-28 Thread René J . V . Bertin
Kai Uwe Broulik wrote: >> A priori users should then still be able to use Qt's native Macintosh "aqua" > theme by selecting it as their KDE widget style. > > I think it should do that automatically anyway. I wouldn't want to install > System Settings to begin with, let alone manually choosing

Re: setting default widgetStyle (and ColorScheme)

2015-11-28 Thread René J . V . Bertin
Olivier Goffart wrote: > > A pure KF5 appliation would anyway use the KDE platform theme plugin provided > by KDE Frameworks. (in frameworkintegration) > (So in other words: that code should not be executed when kde frameworks is > installed, in theory) So... No, it doesn't. Not on OS X when

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-27 Thread Olivier Goffart
On Friday 27. November 2015 23:39:07 René J.V. Bertin wrote: > Digging through Qt's source code to figure out if and how I can get KF5 > applications to honour theming settings on OS X, I observe the following in > class QKdeThemePrivate in qgenericunixthemes.cpp: > > static QString

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-27 Thread René JV Bertin
On 28 Nov 2015, at 01:07, Olivier Goffart wrote: >> >> A pure KF5 system will not have ~/.kde*/share/config/kdeglobals, correct? > > That code was written for integrating into KDE 4. > It was not adapted to work with Plasma 5. > > A pure KF5 appliation would anyway use

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-27 Thread Aleix Pol
On Sat, Nov 28, 2015 at 3:07 AM, René JV Bertin wrote: > > > On 28 Nov 2015, at 01:07, Olivier Goffart wrote: > >>> >>> A pure KF5 system will not have ~/.kde*/share/config/kdeglobals, correct? >> >> That code was written for integrating into KDE 4. >> It

setting default widgetStyle (and ColorScheme)

2015-11-27 Thread René J . V . Bertin
Hi, Apologies is this is a bit off-topic: How does one set/define the default widgetStyle for KF5 applications? I'm now at the point where have been able to build a style (QtCurve), and can request it via the --style argument when launching the few example applications I have (not

Re: setting default widgetStyle (and ColorScheme)

2015-11-27 Thread René J . V . Bertin
Digging through Qt's source code to figure out if and how I can get KF5 applications to honour theming settings on OS X, I observe the following in class QKdeThemePrivate in qgenericunixthemes.cpp: static QString kdeGlobals(const QString ) { return kdeDir +

Re: [Development] setting default widgetStyle (and ColorScheme)

2015-11-27 Thread René J . V . Bertin
On Saturday November 28 2015 01:07:17 Olivier Goffart wrote: > > A pure KF5 system will not have ~/.kde*/share/config/kdeglobals, correct? > > That code was written for integrating into KDE 4. That much was clear :) > A pure KF5 appliation would anyway use the KDE platform theme plugin

Re: setting default widgetStyle (and ColorScheme)

2015-11-27 Thread René J . V . Bertin
On Friday November 27 2015 22:31:09 René J.V. Bertin wrote: Further observation: my font selection is also affected. The only way to get "my" widget style, fonts and colours by default is by using the Qt's Xcb plugin (unsupported, but currently it still builds) and setting KDE_FULL_SESSION=true