On Aug. 9, 2013, 9:27 p.m., David Faure wrote:
tier1/kconfig/src/gui/kconfigloader.h, line 99
http://git.reviewboard.kde.org/r/111908/diff/4/?file=177609#file177609line99
I wonder if this should really derive from KConfigSkeleton, rather than
encapsulate it.
For
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112679/#review39864
---
staging/kservice/src/services/ktraderparsetree.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112680/#review39865
---
staging/kservice/src/plugin/kplugintrader.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/#review39866
---
General approach looks good.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review39867
---
Ship it!
OK then.
- David Faure
On Aug. 9, 2013, 12:38
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112570/
---
Status
--
This change has been marked as submitted.
Review request
See http://build.kde.org/job/kdelibs_frameworks_qt5/1178/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112682/
---
Review request for KDE Frameworks.
Description
---
simple move from
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/
---
(Updated Sept. 12, 2013, 1:19 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/#review39878
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112684/
---
Review request for KDE Frameworks, David Faure and Aurélien Gâteau.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112685/
---
Review request for KDE Frameworks and Martin Gräßlin.
Description
---
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112682/#review39883
---
Ship it!
It was added in master 2 months ago more or less, I
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112682/#review39885
---
This review has been submitted with commit
On Thursday 12 September 2013 16:18:12 Aurélien Gâteau wrote:
Hi,
I started working on the KInterProcessWindowing (kiw) framework, which is
expected to go into tier2 because it depends on KWindowSystem (tier1).
kiw is made of two set of files:
kmessagebox_kiw.*: KMessageBox functions to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112685/#review39884
---
tier1/kwindowsystem/src/kwindowsystem_x11.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112689/
---
Review request for KDE Frameworks.
Description
---
It's not really
Hi,
I started working on the KInterProcessWindowing (kiw) framework, which is
expected to go into tier2 because it depends on KWindowSystem (tier1).
kiw is made of two set of files:
kmessagebox_kiw.*: KMessageBox functions to show message boxes on top of
foreign windows. Depends on
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112696/
---
Review request for KDE Frameworks.
Description
---
Not much else
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112699/
---
Review request for KDE Frameworks and Stephen Kelly.
Description
---
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112702/
---
(Updated Sept. 12, 2013, 6:26 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112689/#review39914
---
- Chusslove Illich
On Sept. 12, 2013, 4:47 p.m., Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/
---
(Updated Sept. 12, 2013, 7:07 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112702/
---
Review request for KDE Frameworks and kdelibs.
Description
---
This
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112700/#review39911
---
- Chusslove Illich
On Sept. 12, 2013, 8 p.m., Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112680/
---
(Updated Sept. 12, 2013, 9:15 p.m.)
Review request for KDE Frameworks and
On Sept. 12, 2013, 9:06 p.m., Chusslove Illich wrote:
[: Aleix Pol Gonzalez :]
It's not really adding much value here, so I'd say we can drop it.
I agree that none of these strings seem like they would need ki18n's
specialties.
(I can't comment on what the proper form of tr() is for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112700/
---
Review request for KDE Frameworks and Chusslove Illich.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112700/#review39913
---
Ship it!
Ship It!
- Chusslove Illich
On Sept. 12, 2013, 8
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/
---
(Updated Sept. 12, 2013, 5 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112697/
---
Review request for Build System, KDE Frameworks and Stephen Kelly.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112697/#review39918
---
Would this break the superbuild stuff Alex was working on?
-
On Sept. 12, 2013, 9:01 p.m., Chusslove Illich wrote:
[: Aleix Pol Gonzalez :]
NOTE: KI18n is marked as tier2 because ktranscript is linking to kjs.
Would it be possible to move this to kde-runtime or create a separate
plugin what depends on something different?
There was exactly this
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112682/
---
(Updated Sept. 12, 2013, 2:20 p.m.)
Status
--
This change has been
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote:
staging/kservice/src/services/kplugininfo.cpp, line 61
http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61
I think that two variables (hidden and _hidden) so similar are
confusing.
Sebastian Kügler
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112699/#review39917
---
Move the finders from kdoctools/CMakeLists.txt to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112685/
---
(Updated Sept. 12, 2013, 5:20 p.m.)
Review request for KDE Frameworks and
On Sept. 12, 2013, 8:04 p.m., Stephen Kelly wrote:
Would this break the superbuild stuff Alex was working on?
I have no idea, I hope not... Where can I learn more about it?
- Aleix
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112685/#review39889
---
I think you uploaded the old diff. Concerning the assert: good
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112685/
---
(Updated Sept. 12, 2013, 4:55 p.m.)
Review request for KDE Frameworks and
40 matches
Mail list logo
