Re: update your cmake!

2013-10-11 Thread Kevin Ottens
Hello, On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Ok... that came as unexpected. I thought we'd handle the upgrade to 2.8.12 in a nicer way learning from past

Re: KF5 Update Meeting Minutes 2013-w41

2013-10-11 Thread David Faure
On Tuesday 08 October 2013 17:09:04 Kevin Ottens wrote: * teo is waiting on dfaure's kfile changes to wrap up KEncodingFileDialog refactoring; My changes are in - i.e. KIO::FileWidgets exists now, under staging/kio/src/filewidgets. KEncodingFileDialog should move to that new library.

Re: [Kde-hardware-devel] libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-11 Thread Alex Richardson
Am Donnerstag, 10. Oktober 2013, 00:11:45 schrieb Sebastian Kügler: On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote: I have added this to some of my qt5 projects and it worked: add_definitions(-fPIC) Thanks Daniel, that helps. :) 2013/10/9 Sebastian Kügler

Review Request 113197: KMessageBox: Factorize code between regular and *WId functions

2013-10-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113197/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: [Kde-hardware-devel] libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-11 Thread Stephen Kelly
Alex Richardson wrote: Am Donnerstag, 10. Oktober 2013, 00:11:45 schrieb Sebastian Kügler: On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote: I have added this to some of my qt5 projects and it worked: add_definitions(-fPIC) Thanks Daniel, that helps. :) 2013/10/9

[extra-cmake-modules] /: Require CMake 2.8.12.

2013-10-11 Thread Stephen Kelly
Git commit 6f4b7ead789b186a1e570366756bf48c34d6ccbf by Stephen Kelly. Committed on 11/10/2013 at 09:36. Pushed by skelly into branch 'master'. Require CMake 2.8.12. As agreed. CCMAIL: kde-frameworks-devel@kde.org M +1-1CMakeLists.txt

Build failed in Jenkins: kdelibs_frameworks_qt5 #1395

2013-10-11 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1395/changes Changes: [steveire] Remove erroneous line. [steveire] Require CMake 2.8.12. [steveire] Update required ECM to version 0.0.9. -- [...truncated 1226 lines...] CMake Error in

Build failed in Jenkins: kdelibs_frameworks_qt5 #1396

2013-10-11 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1396/changes Changes: [steveire] Add ALIAS targets matching exported names. -- [...truncated 1225 lines...] CMake Error in tier1/sonnet/src/core/CMakeLists.txt: Target SonnetCore has policy CMP0022

Setting an empty link interface (Was: Build failed in Jenkins: kdelibs_frameworks_qt5 #1395)

2013-10-11 Thread Stephen Kelly
KDE CI System wrote: [steveire] Require CMake 2.8.12. CMake Error in tier1/sonnet/src/core/CMakeLists.txt: Target SonnetCore has policy CMP0022 enabled, but also has old-style LINK_INTERFACE_LIBRARIES properties populated, but it was exported without the EXPORT_LINK_INTERFACE_LIBRARIES to

KCapacityBar's painting code

2013-10-11 Thread David Faure
Hi Stephen, The commit below removed the initialisation of d-ce_capacityBar, but this variable is still used in KCapacityBar::drawCapacityBar. Can we remove that block of code completely? commit daef0997ef7dab76a5b0ace55cbe1009f8a86c0d Author: Stephen Kelly steve...@gmail.com Date: Mon May 14

Re: KCapacityBar's painting code

2013-10-11 Thread Stephen Kelly
David Faure wrote: Hi Stephen, The commit below removed the initialisation of d-ce_capacityBar, but this variable is still used in KCapacityBar::drawCapacityBar. Can we remove that block of code completely? Since the [...] contains the actual painting code, I assume the above block can

Build failed in Jenkins: kdelibs_frameworks_qt5 #1397

2013-10-11 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1397/changes Changes: [steveire] Port some use of the KArchive target to KF5::KArchive [steveire] Port some KCoreAddons use to KF5::KCoreAddons. -- [...truncated 1226 lines...] CMake Error in

Re: update your cmake!

2013-10-11 Thread Stephen Kelly
Stephen Kelly wrote: Oh... this means we can now make use of ALIAS targets and build truly standalone frameworks \o/ I have a way to script that, but it can't be done yet. I added the ALIAS targets with a script and ported some cases to KF5::Foo, but I think mostly it has to be done

Build failed in Jenkins: kdelibs_frameworks_qt5 #1398

2013-10-11 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1398/changes Changes: [faure] Make KFileDialog use KFileWidget directly again (no more kfilemodule plugin) [faure] Add missing initialization of enabled member variable [faure] Fix assert when the KLineEdit gets a child on construction

Build failed in Jenkins: kdelibs_frameworks_qt5 #1399

2013-10-11 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1399/changes Changes: [faure] Fix wrong usage of ecm_mark_as_test and add_test -- [...truncated 1225 lines...] CMake Error in tier1/sonnet/src/core/CMakeLists.txt: Target SonnetCore has policy

Re: Compiling Plasma-Framework with a QT5 compiled with -egl -opengl es2

2013-10-11 Thread nerdopolis
On Thursday, October 10, 2013 12:00:04 PM kde-frameworks-devel-requ...@kde.org wrote: Is this a bug I should file? no need to file a bug about it. It's code I have written and I know that it currently requires glx. The problem here is that GLX is found on your system but Qt is compiled as

Review Request 113199: KHTML: KComponentData - KAboutData

2013-10-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113199: KHTML: KComponentData - KAboutData

2013-10-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/#review41556 --- khtml/src/khtmlimage.cpp

Re: Review Request 113199: KHTML: KComponentData - KAboutData

2013-10-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/#review41558 --- Ship it! Looks quite straightforward to me, happy to see

Re: Review Request 113170: Document KInit dependencies

2013-10-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- (Updated Oct. 11, 2013, 2 p.m.) Review request for KDE Frameworks.

Re: Review Request 113170: Document KInit dependencies

2013-10-11 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/#review41563 --- Ship it! Looks good ! - Àlex Fiestas On Oct. 11, 2013, 2

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-11 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/#review41564 --- Ship it! Besides this additional changes in the patch that

Build failed in Jenkins: kdelibs_frameworks_qt5 #1401

2013-10-11 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1401/changes Changes: [steveire] Update the link interface. -- [...truncated 1225 lines...] CMake Error in tier1/sonnet/src/core/CMakeLists.txt: Target SonnetCore has policy CMP0022 enabled, but also

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-11 Thread Aleix Pol Gonzalez
On Oct. 11, 2013, 2:03 p.m., Àlex Fiestas wrote: tier1/kjs/src/wtf/Platform.h, lines 36-40 http://git.reviewboard.kde.org/r/113174/diff/2/?file=200451#file200451line36 This has been already pushed, no? Yes, it's in already, it wasn't part of that patch. - Aleix

Re: Review Request 113170: Document KInit dependencies

2013-10-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- (Updated Oct. 11, 2013, 3:38 p.m.) Status -- This change has been

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-11 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review41567 --- Ship it! Ship It! - Kevin Ottens On Oct. 6, 2013, 9:02

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

2013-10-11 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/ --- (Updated Oct. 11, 2013, 2:25 p.m.) Review request for KDE Frameworks.

Review Request 113206: Make KIconLoader a bit less fragile

2013-10-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113206/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-11 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- Review request for KDE Frameworks and kdelibs. Repository: kdelibs

Re: Review Request 113206: Make KIconLoader a bit less fragile

2013-10-11 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113206/#review41569 --- Ship it! When I touched this code I was tempted of doing

Re: Review Request 113206: Make KIconLoader a bit less fragile

2013-10-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113206/ --- (Updated Oct. 11, 2013, 6:07 p.m.) Status -- This change has been

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1406

2013-10-11 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1406/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: build.kde.org: Failing ktoolbar_unittest

2013-10-11 Thread Aleix Pol
On Fri, Oct 11, 2013 at 6:31 PM, Kevin Ottens er...@kde.org wrote: Hello, ktoolbar_unittest segfaults in the CI. I tried to reproduce the error here with no luck so far. If someone who manages to reproduce it or who has access to build.kde.org shell could look into it that would be nice.

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-11 Thread Mark Gaiser
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Interesting. So that mean we simply can't use the new signal/slot syntax because of it? That would seem rather strange to

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-11 Thread Sune Vuorela
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Mark Gaiser wrote: Interesting. So that mean we simply can't use the new signal/slot syntax because of it?