Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

2013-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/#review41573 --- Ship it! So time_t does exist on Windows? Very interesting, I

Re: Categorized logging in KDE?

2013-10-12 Thread David Faure
On Wednesday 09 October 2013 15:29:56 Mark wrote: Hi, As you all probably know by now, Qt has included of categorized logging [1] as of 5.2. In KDE we've had categorized logging for ages, but while porting to Frameworks we started using the simple Qt logging qDebug, Notice and Warning.

Re: Review Request 113199: KHTML: KComponentData - KAboutData

2013-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/#review41575 --- Ship it! Ship It! - David Faure On Oct. 11, 2013, 12:16

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1413

2013-10-12 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1413/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113157: Remove Nepomuk dependency from kde4support

2013-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113157/#review41579 --- Ship it! Ship It! - David Faure On Oct. 7, 2013, 5:25

Review Request 113215: Fix casing in KPty cmake vars

2013-10-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/ --- Review request for KDE Frameworks. Repository: kdelibs Description

KNotifyConfig cmake vars problem

2013-10-12 Thread Sebastian Kügler
Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. When applying the attached patch to KNotifyConfig (which I believe should add the right variables), I'm getting CMake Error at /home/sebas/kf5/install/lib/x86_64-linux-

[extra-cmake-modules] find-modules: Remove the check for the LIBRARIES variable.

2013-10-12 Thread Stephen Kelly
Git commit b6ddac117f6e0d3e4a88ddaf8fbb769756f367ca by Stephen Kelly. Committed on 12/10/2013 at 12:24. Pushed by skelly into branch 'master'. Remove the check for the LIBRARIES variable. It is redundant and obsolete. Some frameworks can have erroneous values (eg KConfigWidgets currently sets

Re: [extra-cmake-modules] find-modules: Remove the check for the LIBRARIES variable.

2013-10-12 Thread Stephen Kelly
Stephen Kelly wrote: Some frameworks can have erroneous values (eg KConfigWidgets currently Oops, I meant KNotifyConfig. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KNotifyConfig cmake vars problem

2013-10-12 Thread Stephen Kelly
Sebastian Kügler wrote: Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. Update your ecm, and konsole repos and discard your patch. It is not needed. Thanks, Steve. ___

Build failed in Jenkins: plasma-framework_master_qt5 #802

2013-10-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/802/changes Changes: [stephen.kelly] Remove obsolete include_directories use. -- [...truncated 475 lines...] Generating moc_customDataContainersEngine.cpp Generating moc_httpContainer.cpp [ 16%]

Build failed in Jenkins: plasma-framework_master_qt5 #803

2013-10-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/803/changes Changes: [stephen.kelly] Try to fix the plasma include dirs failure on bko. -- [...truncated 464 lines...]

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread Mark Gaiser
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Mark Gaiser wrote: Interesting. So that mean we simply can't use the new signal/slot syntax because of it?

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread David Faure
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Mark Gaiser wrote: Interesting. So that mean we simply can't use the new signal/slot syntax because of it?

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/#review41602 --- tier3/kpty/KPtyConfig.cmake.in

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review41603 --- kded/kbuildsycoca.cpp

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- (Updated Oct. 12, 2013, 6:30 p.m.) Review request for KDE Frameworks,

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/ --- (Updated Oct. 12, 2013, 6:55 p.m.) Review request for KDE Frameworks.

plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
Hi Steve, It seems that one of your recent commits to plasma-frameworks broke its build: /home/sebas/kf5/src/plasma- framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23:23: fatal error: qtest_kde.h: No such file or directory Readding the things you removed

Build failed in Jenkins: plasma-framework_master_qt5 #805

2013-10-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/805/changes Changes: [sebas] Revert bef789642e4bc245b -- [...truncated 25 lines...] libstreams - Branch master phonon - Branch master extra-cmake-modules - Branch master

Re: plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
On Saturday, October 12, 2013 21:48:28 Sebastian Kügler wrote: It seems that one of your recent commits to plasma-frameworks broke its build: /home/sebas/kf5/src/plasma- framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltes t.cpp:23:23: fatal error: qtest_kde.h: No

Re: KNotifyConfig cmake vars problem

2013-10-12 Thread Sebastian Kügler
On Saturday, October 12, 2013 14:29:19 Stephen Kelly wrote: Sebastian Kügler wrote: Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. Update your ecm, and konsole repos and discard your patch. It is not needed. Thanks,

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

2013-10-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/#review41623 --- This review has been submitted with commit

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

2013-10-12 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/ --- (Updated Oct. 13, 2013, 3:19 a.m.) Status -- This change has been

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #1423

2013-10-12 Thread Nicolás Alvarez
2013/10/13 KDE CI System n...@kde.org: See http://build.kde.org/job/kdelibs_frameworks_qt5/1423/changes This is a failure in a KArchive test, regarding the assertion dt.secsTo(creationTime) = 1. The change that triggered this build only added comments in KDirWatch; nowhere near the KArchive

Review Request 113226: Cleanup kdirwatch includes.

2013-10-12 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113226/ --- Review request for KDE Frameworks. Repository: kdelibs Description