Re: KF5 Update Meeting Minutes 2013-w44

2013-10-31 Thread David Faure
On Tuesday 29 October 2013 20:28:55 Martin Klapetek wrote: On Tue, Oct 29, 2013 at 4:59 PM, Kevin Ottens er...@kde.org wrote: snip * dfaure is making progress toward killing libkio; * he's waiting on mck182 to deal with KImageIO; That's probably not me, I've not been doing anything

Re: Getting ecm files from the ECM package

2013-10-31 Thread David Faure
On Wednesday 30 October 2013 21:19:43 Alexander Neundorf wrote: On Wednesday 30 October 2013, Stephen Kelly wrote: Hello, Soon I will be replacing code like find_package(KF5 REQUIRED CMake Compiler InstallDirs) with include(KDEInstallDirs) include(KDECMakeSettings)

Re: Getting ecm files from the ECM package

2013-10-31 Thread Stephen Kelly
Alexander Neundorf wrote: find_package(KF5 ... COMPONENTS karchive solid kcompletion) call in their CMakeLists.txt and get the same results. And if this works for tier3 libs, why not just do the same in tier2 and also in tier1... Because tier1 doesn't depend on or find KF5 at all, by

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-10-31 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/ --- (Updated Oct. 31, 2013, 10:15 a.m.) Status -- This change has been

Jenkins build is back to stable : kdelibs_stable #880

2013-10-31 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/880/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113496: Move Kross from staging to tier3

2013-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113496/#review42732 --- This review has been submitted with commit

Re: Review Request 113496: Move Kross from staging to tier3

2013-10-31 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113496/ --- (Updated Oct. 31, 2013, 10:51 a.m.) Status -- This change has been

Re: Review Request 113511: Install KSslSettings header

2013-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113511/#review42737 --- Ship it! staging/kio/src/core/CMakeLists.txt

Re: Review Request 113507: Use ecm_mark_as_test for test-only targets

2013-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113507/#review42738 --- Ship it! Looks good. - David Faure On Oct. 30, 2013, 3:59

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-31 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42743 --- Ping, this seems forgotten :) - Martin Klapetek On Oct. 22,

Re: Review Request 113503: make dbus dependency optional in JobWidgets

2013-10-31 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/#review42744 --- tier2/kjobwidgets/CMakeLists.txt

Re: Review Request 113511: Install KSslSettings header

2013-10-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113511/ --- (Updated Oct. 31, 2013, 4:39 p.m.) Status -- This change has been

Re: Review Request 113511: Install KSslSettings header

2013-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113511/#review42749 --- This review has been submitted with commit

Re: Getting ecm files from the ECM package

2013-10-31 Thread Alexander Neundorf
On Thursday 31 October 2013, David Faure wrote: On Wednesday 30 October 2013 21:19:43 Alexander Neundorf wrote: On Wednesday 30 October 2013, Stephen Kelly wrote: Hello, Soon I will be replacing code like find_package(KF5 REQUIRED CMake Compiler InstallDirs) with

Re: Getting ecm files from the ECM package

2013-10-31 Thread Alexander Neundorf
On Thursday 31 October 2013, Stephen Kelly wrote: Alexander Neundorf wrote: find_package(KF5 ... COMPONENTS karchive solid kcompletion) call in their CMakeLists.txt and get the same results. And if this works for tier3 libs, why not just do the same in tier2 and also in tier1...

Review Request 113522: Improve documentation in ECMInstallIcons.cmake

2013-10-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/ --- Review request for KDE Frameworks. Repository: extra-cmake-modules

Re: Getting ecm files from the ECM package

2013-10-31 Thread David Faure
On Thursday 31 October 2013 17:54:06 Alexander Neundorf wrote: IOW, those three files exist only for KF5, and no other reason. This contradicts use KDECMakeSettings.cmake in gammaray if you want automatic RPATH handling as you told me some time ago. In other words, these things are convenience

Re: Review Request 113505: Add unit tests for KTranscript

2013-10-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113505/ --- (Updated Oct. 31, 2013, 6:44 p.m.) Status -- This change has been

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-10-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Oct. 31, 2013, 6:50 p.m.) Review request for KDE Frameworks and

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-10-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Oct. 31, 2013, 7:28 p.m.) Review request for KDE Frameworks and

Jenkins build became unstable: kdelibs_stable #881

2013-10-31 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/881/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_stable #884

2013-10-31 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/884/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-10-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Oct. 31, 2013, 10:37 p.m.) Review request for KDE Frameworks,

Review Request 113527: Fix KPassivePopup placement

2013-10-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

2013-10-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/ --- (Updated Oct. 31, 2013, 11:30 p.m.) Review request for KDE Frameworks.