On Tuesday 07 January 2014 07:12:40 Christoph Cullmann wrote:
I tried my luck with splitting/grafting/kdeexamples template.
Could somebody take a look what ended up in the master branch of
g...@git.kde.org:scratch/cullmann/ktexteditor.git
Any feedback welcome, if I
On Tue, Jan 7, 2014 at 9:37 AM, Christoph Cullmann cullm...@absint.comwrote:
Should the heuristic be: If there is a K in front, remove it and do stuff
like
KFooBar leads to KF5FooBar, else keep the complete FooBar name and do
KF5FooBar.
Yes, pretty much that.
Cheers
--
Martin Klapetek |
On 06/01/14 06:52, Kevin Ottens wrote:
I used to say that the maintenance model of kdelibs was David Faure by
default. It's great to have someone like David around, but at the same time
it's delusional and dangerous to think that he'll always be able to save the
day. This model has to stop
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114895/
---
Review request for KDE Frameworks, Martin Gräßlin and Marco Martin.
On Jan. 7, 2014, 2:14 p.m., Martin Gräßlin wrote:
checking obviously makes sense, though it shouldn't be needed. There must
be something else which is wrong here, too.
Could you try what the value of WId is in these cases? I wouldn't be
surprised if it were 0.
Oh and that code
On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote:
checking obviously makes sense, though it shouldn't be needed. There must
be something else which is wrong here, too.
Could you try what the value of WId is in these cases? I wouldn't be
surprised if it were 0.
Oh and that code
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/
---
(Updated Jan. 7, 2014, 3:22 p.m.)
Review request for Build System, KDE
Hello everyone,
This is the minutes of the Week 48 KF5 meeting. As usual it has been held on
#kde-devel at 4pm Paris time.
Were present: afiestas, agateau, alexmerry, apol, d_ed, mck182, mgraesslin,
Riddell, sandsmark, sebas, svuorela and myself.
Announcement:
* Happy new year!
* TP1 is
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 34
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line34
add_compiler_export_flags() should not be used at all.
On Tuesday 07 January 2014 07:22:01 Kevin Ottens wrote:
On Tuesday 07 January 2014 00:45:19 Christoph Feck wrote:
On Monday 06 January 2014 23:54:46 Kevin Ottens wrote:
On Monday 06 January 2014 22:26:27 Alexander Neundorf wrote:
IMO something like proposing the maintainers and approving
Hello,
As a reminder the maintainers list is available there:
http://community.kde.org/Frameworks/List
People willing to maintain a framework should put their name in the
corresponding column.
On Tuesday 07 January 2014 16:53:30 Kevin Ottens wrote:
* agateau plans to work on kapidox, [...]
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 25
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line25
Setting CMAKE_CXX_FLAGS is not 'modern cmake'. Prefer to use
add_compile_options instead.
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 25
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line25
Setting CMAKE_CXX_FLAGS is not 'modern cmake'. Prefer to use
add_compile_options instead.
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 25
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line25
Setting CMAKE_CXX_FLAGS is not 'modern cmake'. Prefer to use
add_compile_options instead.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/
---
(Updated Jan. 7, 2014, 4:30 p.m.)
Review request for Build System, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114897/
---
Review request for Build System, KDE Frameworks and Stephen Kelly.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114897/#review46984
---
Why is -UQT_NO_EXCEPTIONS needed?
- Stephen Kelly
On Jan.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898/#review46985
---
Ship it!
Does test code need to be compiled with the flags?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898/
---
Review request for Build System, KDE Frameworks and Stephen Kelly.
On 6 January 2014 07:52, Kevin Ottens er...@kde.org wrote:
I urge everyone, and in particular people volunteering to maintain a
framework, to do a pass of review of our code base and APIs to modernize them
when appropriate. It is a very big task, and in no way can be coordinated in
the way
On Jan. 7, 2014, 4:55 p.m., Stephen Kelly wrote:
Why is -UQT_NO_EXCEPTIONS needed?
Hrm. After some investigation: I'm not entirely sure. The simplest answer is
that's what qmake does - defines QT_NO_EXCEPTIONS exactly when exceptions are
disabled (note that exceptions are disabled by
Hello,
I am also looking to maintain a project, if there is something where i can
help. I would try to join the meeting.
Regards,
Siddharth Sharma
On Tue, Jan 7, 2014 at 9:23 PM, Kevin Ottens er...@kde.org wrote:
Hello everyone,
This is the minutes of the Week 48 KF5 meeting. As usual
On Jan. 7, 2014, 4:55 p.m., Stephen Kelly wrote:
Why is -UQT_NO_EXCEPTIONS needed?
Alex Merry wrote:
Hrm. After some investigation: I'm not entirely sure. The simplest
answer is that's what qmake does - defines QT_NO_EXCEPTIONS exactly when
exceptions are disabled (note that
On 07/01/14 16:28, Kevin Ottens wrote:
* alexmerry [...] plans to adopt kimageformats and kmediaplayer;
Alex: Both KImageFormats and KMediaPlayer are your if you adjust the wiki
page
accordingly.
I've also taken KDesignerPlugin; as far as I'm aware, I'm the only
person to have done
On 07/01/14 17:10, John Layt wrote:
I've put myself down (rather obviously) for KPrintUtils. Most of the
dialog code from there has been merged into Qt5.2, or is planned for
Qt 5.3, so needs deleting. I'm also wondering if we still need our
own KPrintPreview dialog, there was a reason in 4.0
On 07/01/14 18:00, Stephen Kelly wrote:
Alex Merry wrote:
Hrm. After some investigation: I'm not entirely sure. The simplest
answer is that's what qmake does
Please tell me you noticed that I asked about -U, not -D ...
Yes. qmake actually doesn't use -U directly; it simply sets
On Sunday 05 January 2014 13:42:49 David Faure wrote:
I made and uploaded the tarballs (and zips) for the TP1 release.
Let's give the packagers a few days, and then we'll publish and announce the
release.
Meanwhile, no major changes in frameworks please, in case I need to redo
tarballs.
El Dimarts, 7 de gener de 2014, a les 17:28:29, Kevin Ottens va escriure:
Hello,
As a reminder the maintainers list is available there:
http://community.kde.org/Frameworks/List
Can I suggest changing Unmaintained to looking for a maintainer?
It looks pretty bad that we released a the
El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure:
On 07/01/14 17:10, John Layt wrote:
I've put myself down (rather obviously) for KPrintUtils. Most of the
dialog code from there has been merged into Qt5.2, or is planned for
Qt 5.3, so needs deleting. I'm also
Hi,
I just tried to fix the naming issues.
Does that try here look better
http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git
If yes, I would ask sysadmin to move to framworks, if that is ok and remove the
stuff in frameworks branch
of kate.git.
Greetings
Christoph
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/#review46996
---
Ship it!
Nice, this also fixes some inconsistencies between
Git commit 4068592ad9aa3f241027f6dbd6aff5f756671fd3 by Alex Merry.
Committed on 03/01/2014 at 12:14.
Pushed by alexmerry into branch 'master'.
Remove custom build types
KDECompilerSettings.cmake no longer alters CMake's built-in build types
or adds its own. The debug build type therefore simply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/
---
(Updated Jan. 7, 2014, 7:13 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/#review46997
---
This review has been submitted with commit
On Tuesday 07 January 2014 19:57:56 Christoph Cullmann wrote:
Hi,
I just tried to fix the naming issues.
Does that try here look better
http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git
I see a ${FooBar_HEADERS} in src/CMakeLists.txt which is used but not set,
should be
On Tuesday 07 January 2014 19:57:56 Christoph Cullmann wrote:
Hi,
I just tried to fix the naming issues.
Does that try here look better
http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git
I see a ${FooBar_HEADERS} in src/CMakeLists.txt which is used but not set,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898/#review47000
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898/
---
(Updated Jan. 7, 2014, 7:46 p.m.)
Status
--
This change has been
See http://build.kde.org/job/kwindowsystem_master_qt5/11/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hiya Folks,
I want to give a helping hand to that task, hence added my name. So if i
understood correctly does it needs to be done with kde4support, i mean
kde4support - kf5support ?
Regards,
Siddharth Sharma
___
Kde-frameworks-devel mailing list
add_library (KF5TextEditor ${ktexteditor_LIB_SRCS}
${KTEXTEDITOR_PUBLIC_HEADERS})
Why pass headers to add_library?
Just for automoc, without that, I get stuff like:
Linking CXX shared library libKF5TextEditor.so
CMakeFiles/KF5TextEditor.dir/view/kateviewinternal.cpp.o: In
On Wednesday 08 January 2014 01:17:50 Siddharth Sharma wrote:
Hiya Folks,
I want to give a helping hand to that task, hence added my name. So if i
understood correctly does it needs to be done with kde4support, i mean
kde4support - kf5support ?
Definitely not :) kde4support is kde4support
add_library (KF5TextEditor ${ktexteditor_LIB_SRCS}
${KTEXTEDITOR_PUBLIC_HEADERS})
Why pass headers to add_library?
Just for automoc, without that, I get stuff like:
Linking CXX shared library libKF5TextEditor.so
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114897/
---
(Updated Jan. 7, 2014, 7:58 p.m.)
Review request for Build System, KDE
Aha :) , Ok on it
On Wed, Jan 8, 2014 at 1:20 AM, David Faure fa...@kde.org wrote:
On Wednesday 08 January 2014 01:17:50 Siddharth Sharma wrote:
Hiya Folks,
I want to give a helping hand to that task, hence added my name. So if i
understood correctly does it needs to be done with
On Tuesday 07 January 2014 20:55:19 Christoph Cullmann wrote:
* run astyle-kdelibs (requires some patching, so I can do it if you want)
Sure, that would be nice.
OK. Can you give a quick look at
http://www.davidfaure.fr/2014/ktexteditor-astyled.diff
and give me a green light?
No
On 07/01/14 20:02, Siddharth Sharma wrote:
Aha :) , Ok on it
On Wed, Jan 8, 2014 at 1:20 AM, David Faure fa...@kde.org
mailto:fa...@kde.org wrote:
No, this is about KDE4_* in extra-cmake-modules for instance. Or in any
CMakeLists.txt files.
The task description looks like it's
On Tuesday 07 January 2014 21:12:39 Christoph Cullmann wrote:
Yeah, 2 = 4, all right, wanted that anyway since long.
Only the autotests/input stuff should be best left untouched. That is no
source in that case only input for tests, and yeah, I guess they won't
like that.
OK, reverted that
Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann:
Hi,
I just tried to fix the naming issues.
Does that try here look better
http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git
If yes, I would ask sysadmin to move to framworks, if that is ok and remove
the
Am Dienstag, 7. Januar 2014, 21:20:40 schrieb Kevin Funk:
Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann:
Hi,
I just tried to fix the naming issues.
Does that try here look better
http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git
If yes, I
On Jan. 7, 2014, 8:46 p.m., Commit Hook wrote:
This review has been submitted with commit
676e746b78d8b6ada47dd15fd706d0deb9996e45 by Alex Merry to branch master.
A bit late, but how about adding the include(GenerateExportHeader) to
KDECMakeSettings.cmake, this way the frameworks don't
Fixed :P
- Ursprüngliche Mail -
Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann:
Hi,
I just tried to fix the naming issues.
Does that try here look better
http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git
If yes, I would ask sysadmin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114903/
---
Review request for Build System, KDE Frameworks and Stephen Kelly.
On Jan. 7, 2014, 7:46 p.m., Commit Hook wrote:
This review has been submitted with commit
676e746b78d8b6ada47dd15fd706d0deb9996e45 by Alex Merry to branch master.
Alexander Richardson wrote:
A bit late, but how about adding the include(GenerateExportHeader) to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114904/#review47008
---
The motivation was that if somebody had set up carefully his
On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote:
The motivation was that if somebody had set up carefully his install dirs
for kdelibs, he simply wanted to point a following project to the same
CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use
the same
On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote:
The motivation was that if somebody had set up carefully his install dirs
for kdelibs, he simply wanted to point a following project to the same
CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use
the same
On 7 January 2014 19:55, Albert Astals Cid aa...@kde.org wrote:
El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure:
On 07/01/14 17:10, John Layt wrote:
I've put myself down (rather obviously) for KPrintUtils. Most of the
dialog code from there has been merged into Qt5.2,
El Dimarts, 7 de gener de 2014, a les 23:10:11, John Layt va escriure:
On 7 January 2014 19:55, Albert Astals Cid aa...@kde.org wrote:
El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure:
On 07/01/14 17:10, John Layt wrote:
I've put myself down (rather obviously) for
On Tuesday 07 of January 2014 23:10:11 John Layt wrote:
On 7 January 2014 19:55, Albert Astals Cid aa...@kde.org wrote:
El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure:
On 07/01/14 17:10, John Layt wrote:
I've put myself down (rather obviously) for KPrintUtils. Most
Alex Merry wrote:
On 07/01/14 18:00, Stephen Kelly wrote:
Alex Merry wrote:
Hrm. After some investigation: I'm not entirely sure. The simplest
answer is that's what qmake does
Please tell me you noticed that I asked about -U, not -D ...
Yes. qmake actually doesn't use -U directly;
On 07/01/14 22:30, John Layt wrote:
Running through the print dialog features, I'm don't think there is
anything left to be upstreamed. There's a couple of very minor CUPS
features in the dialog that I don't think anyone uses (mirror page,
page border, page label) that I don't really want in
On 07/01/14 22:34, Stephen Kelly wrote:
Alex Merry wrote:
On 07/01/14 18:00, Stephen Kelly wrote:
Alex Merry wrote:
Hrm. After some investigation: I'm not entirely sure. The simplest
answer is that's what qmake does
Please tell me you noticed that I asked about -U, not -D ...
Yes.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114903/#review47016
---
This review has been submitted with commit
On Tuesday 07 January 2014 23:30:28 John Layt wrote:
On 7 January 2014 19:49, Kevin Ottens er...@kde.org wrote:
Most of the
dialog code from there has been merged into Qt5.2, or is planned for
Qt 5.3, so needs deleting. I'm also wondering if we still need our
own KPrintPreview dialog,
65 matches
Mail list logo
