Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 7 January 2014 23:30, Michal Humpula michal.hump...@seznam.cz wrote: If I may post a little input here. I've implemented print preview in kate (KF5) with QPrintPreviewDialog, mainly for the reasons mentioned above. But what I'm missing is ability to add custom configuration tabs as in

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 8 January 2014 07:17, Kevin Ottens er...@kde.org wrote: For the record, if that depends on QtPrintSupport it can't make it to KGuiAddons (which should depend only on QtCore and QtGui). Good point :-) I'm fine keeping it even if it's small. OK, I'll take the chainsaw to it this weekend

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread Martin Gräßlin
On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code

Jenkins build is unstable: ktexteditor_master_qt5 #1

2014-01-08 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/1/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 7 January 2014 23:52, Alex Merry k...@randomguy3.me.uk wrote: If these additions are something that applications would need to be aware of, I see no issue with creating a wrapper class or some such as-and-when we find a use for one. If they are something that would be hidden to

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread David Edmundson
On Jan. 7, 2014, 2:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/ --- (Updated Jan. 8, 2014, 12:18 p.m.) Status -- This change has been

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/#review47047 --- This review has been submitted with commit

Jenkins build is back to stable : kwindowsystem_master_qt5 #12

2014-01-08 Thread KDE CI System
See http://build.kde.org/job/kwindowsystem_master_qt5/12/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114888: Avoid // in path in generated headers

2014-01-08 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/ --- (Updated Jan. 8, 2014, 1:22 p.m.) Review request for Extra Cmake Modules

Reviewboard and maintainers

2014-01-08 Thread Alex Merry
Just a note that if you are the maintainer of a framework, you may want to add the following line to the .reviewboardrc file of the git repo: TARGET_PEOPLE = 'kde_username' For example, I would put TARGET_PEOPLE = 'alexmerry' This means that you get CC'd on every review request posted using

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread Martin Gräßlin
On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code

Re: Review Request 114888: Avoid // in path in generated headers

2014-01-08 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/#review47048 --- modules/ECMGenerateHeaders.cmake

Re: [PATCH] Fail early if libsm is not installed

2014-01-08 Thread Aurélien Gâteau
Le dimanche 29 décembre 2013 14:42:53 David Faure a écrit : On Thursday 19 December 2013 18:10:11 Aurélien Gâteau wrote: Hi, Attached patch causes cmake to fail early if libsm is not installed, rather than waiting until we try to build code using it. This patch also removes buggy

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread David Faure
On Wednesday 08 January 2014 12:21:10 John Layt wrote: it may be better moved to KDE4Support, along with KPrintPreview, leaving an empty repo. If that's the conclusion, then an option is just to leave everything in the current repo, and mark the whole repo (and its individual classes) as

Build failed in Jenkins: sonnet_master_qt5 #7

2014-01-08 Thread KDE CI System
See http://build.kde.org/job/sonnet_master_qt5/7/changes Changes: [martin.sandsmark] Start adding back language detection from SVN branch. [martin.sandsmark] Add trigrams. [martin.sandsmark] Add the TextBreaks class. [martin.sandsmark] Add support for finding paragraph breaks to TextBreaks.

Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

2014-01-08 Thread Siddharth Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: KTextEditor Frameworks question

2014-01-08 Thread Kevin Ottens
On Tuesday 07 January 2014 20:48:39 David Faure wrote: The checklist for new frameworks can be extracted from http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation which gives: * make new repo using script (done, in your case) * run astyle-kdelibs (requires some patching, so I

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

2014-01-08 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/#review47089 --- I'll leave someone who knows this better (David Faure?) to

Re: KTextEditor Frameworks question

2014-01-08 Thread Alex Merry
On 08/01/14 22:24, Kevin Ottens wrote: I also modified a bit one of the policies: http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_consistent (was saying installation rules but it's really more about style of the buildsystem, we might want to reference aurélien's

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

2014-01-08 Thread Siddharth Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/ --- (Updated Jan. 8, 2014, 11:23 p.m.) Status -- This change has been