Re: Review Request 114988: Fix PREFIX parameter to ecm_generate_headers to match namespace KNS3

2014-01-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114988/#review47294 --- Well, then it breaks lowercase headers, which have been

Re: KNewStuff3 vs. KNS3 vs. KNewStuff (was: Re: What are the plans with CamelCase includes?)

2014-01-13 Thread David Faure
On Saturday 11 January 2014 02:42:20 Friedrich W. H. Kossebau wrote: There the used namespace does not match the module name: namespace is KNS3, the module name KNewStuff3. That's not a problem, the KIOCore module uses namespace (and therefore prefix) KIO. I just saw this mail, after my reply

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread David Faure
On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I

Re: Review Request 114888: Avoid // in path in generated headers

2014-01-13 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/ --- (Updated Jan. 13, 2014, 11:17 a.m.) Review request for Extra Cmake

Re: Review Request 114888: Avoid // in path in generated headers

2014-01-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/#review47300 --- Ship it! Ship It! - David Faure On Jan. 13, 2014, 10:17

Re: Review Request 114888: Avoid // in path in generated headers

2014-01-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/#review47301 --- This review has been submitted with commit

Re: Review Request 114888: Avoid // in path in generated headers

2014-01-13 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/ --- (Updated Jan. 13, 2014, 10:47 a.m.) Status -- This change has been

Re: Review Request 114962: Improve dependency specifications

2014-01-13 Thread Alex Merry
On Jan. 11, 2014, 8:02 p.m., Alex Merry wrote: This should be using QT_REQUIRED_VERSION everywhere. Actually, if you could change it in the other CMakeLists.txt files, that would be good. Then it can be shipped. Michael Palimaka wrote: No worries, will do. I only explicitly

Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs

2014-01-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/#review47308 --- Does kde5_install_icons even exist? I can't find its

Re: Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

2014-01-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114989/#review47309 --- kde5-config is not a thing. kf5-config does, but is provided

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114990/#review47310 --- src/kauthactionreply.h

Re: Review Request 114991: I think frameworks 5 should use kde5 based emoticons ? , though i am not sure changing it now would make any sense o_O ? would leave up to reviewers

2014-01-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114991/#review47311 --- Currently, it is still kde4; it is tied to

Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs

2014-01-13 Thread Alex Merry
On Jan. 13, 2014, 11:54 a.m., Alex Merry wrote: Does kde5_install_icons even exist? I can't find its definition in extra-cmake-modules. You say you've done no testing; surely you should at least have tried a fresh configure, compile and install of khtml? Also, I would ignore

Review Request 114997: Improve KAuth README.md

2014-01-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- Review request for KDE Frameworks and Dario Freddi. Repository: kauth

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Siddharth Sharma
so basically of all yesterdays review requests, were to know if things would change over there or not. did not replaced everything with kde4 - kde5 On Mon, Jan 13, 2014 at 5:39 PM, Alex Merry k...@randomguy3.me.uk wrote: This is an automatically generated e-mail. To reply, visit:

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Alex Merry
On 13/01/14 12:41, Siddharth Sharma wrote: so basically of all yesterdays review requests, were to know if things would change over there or not. did not replaced everything with kde4 - kde5 OK, sorry if I came across a bit harsh; I know you're still getting familiar with the frameworks. The

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Siddharth Sharma
Thanks looking into porting guide , will do legitimate requests next time. :) ~siddharth On Mon, Jan 13, 2014 at 6:15 PM, Alex Merry k...@randomguy3.me.uk wrote: On 13/01/14 12:41, Siddharth Sharma wrote: so basically of all yesterdays review requests, were to know if things would change

Re: KDE Frameworks on Inqlude

2014-01-13 Thread Jos Poortvliet
On Sunday 12 January 2014 23:11:09 Cornelius Schumacher wrote: KDE Frameworks now have a dedicated page on Inqlude. There is a group listing all frameworks at http://inqlude.org/groups/kde-frameworks.html. The intention is not to make them stand out, but to have a logical grouping and one view

KF5 Update Meeting 2014-w3 Reminder

2014-01-13 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed

Re: KDE Frameworks on Inqlude

2014-01-13 Thread Kevin Ottens
Hello, On Sunday 12 January 2014 23:11:09 Cornelius Schumacher wrote: KDE Frameworks now have a dedicated page on Inqlude. There is a group listing all frameworks at http://inqlude.org/groups/kde-frameworks.html. The intention is not to make them stand out, but to have a logical grouping and

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Kevin Ottens
Hello, On Monday 13 January 2014 10:05:26 David Faure wrote: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed,

Re: KDE Frameworks on Inqlude

2014-01-13 Thread Alex Merry
On 13/01/14 16:17, Kevin Ottens wrote: Also makes me wonder if we're duplicating information from http://community.kde.org/Frameworks/List If we duplicate too much of it, we might want to rely completely on the information from the repositories since they're used by inqlude. We could just

Re: KNewStuff3 vs. KNS3 vs. KNewStuff (was: Re: What are the plans with CamelCase includes?)

2014-01-13 Thread Friedrich W. H. Kossebau
Am Montag, 13. Januar 2014, 09:40:57 schrieb David Faure: On Saturday 11 January 2014 02:42:20 Friedrich W. H. Kossebau wrote: There the used namespace does not match the module name: namespace is KNS3, the module name KNewStuff3. That's not a problem, the KIOCore module uses namespace

Re: New doxygen script

2014-01-13 Thread Alex Merry
On 13/01/14 16:15, Aurélien Gâteau wrote: Thanks a lot! I think you should merge your work in already. Once your script can generate a proper index.html page we can ask Allen to set up api.kde.org to use it for frameworks doc. I'm mostly waiting on the review requests I have outstanding - in

kf5dot now supports extra dependencies

2014-01-13 Thread Aurélien Gâteau
Hi, Just a quick note to let you know I finally finished adding support for explicit dependencies to kf5dot. This makes it possible to express dependencies between frameworks which are not included in the Graphviz files generated by CMake. This happens in kdnssd, because depending on the system

Re: KNewStuff3 vs. KNS3 vs. KNewStuff (was: Re: What are the plans with CamelCase includes?)

2014-01-13 Thread David Faure
On Monday 13 January 2014 17:50:25 Friedrich W. H. Kossebau wrote: Those knewstuff3/file.h forwarding headers you are proposing, they would be installed from KDE4Support, right? To [...]/include/KF5/knewstuff3, with the pattern... file entry.h contains: #include kns3/entry.h Ah, good idea.

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Nicolás Alvarez
2014/1/13 David Faure fa...@kde.org: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread David Faure
On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: 2014/1/13 David Faure fa...@kde.org: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/13/2014 05:17 PM, Kevin Ottens wrote: Hello, On Monday 13 January 2014 10:05:26 David Faure wrote: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Do you also plan on doing something with the kwallet repository, i.e. the user-facing application? Well, if you asked me, I

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Kevin Ottens
On Monday 13 January 2014 20:12:31 Valentin Rusu wrote: On 01/13/2014 07:54 PM, David Faure wrote: On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: 2014/1/13 David Faure fa...@kde.org: If you rename kwallet to kwalletmanager and kwallet-framework to kwallet, people with a

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/13/2014 08:40 PM, Kevin Ottens wrote: On Monday 13 January 2014 20:12:31 Valentin Rusu wrote: On 01/13/2014 07:54 PM, David Faure wrote: On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: 2014/1/13 David Faure fa...@kde.org: If you rename kwallet to kwalletmanager and

Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes

2014-01-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/ --- (Updated Jan. 13, 2014, 8:02 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: kwallet-framework_master_qt5 #10

2014-01-13 Thread KDE CI System
See http://build.kde.org/job/kwallet-framework_master_qt5/10/changes Changes: [winter] signals: - Q_SIGNALS and slots: - Q_SLOTS [coolo] merge in the kconfiggroup_port branch: [mueller] fix various issues with non-compiling headers [mueller] some more #include cleanup [aseigo] this is now

Build failed in Jenkins: kwallet-framework_master_qt5 #11

2014-01-13 Thread KDE CI System
See http://build.kde.org/job/kwallet-framework_master_qt5/11/changes Changes: [kde] Fix build -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Build failed in Jenkins: kwallet-framework_master_qt5 #12

2014-01-13 Thread KDE CI System
See http://build.kde.org/job/kwallet-framework_master_qt5/12/changes Changes: [kde] Fix build, once again... -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: kwallet-framework_master_qt5 #13

2014-01-13 Thread KDE CI System
See http://build.kde.org/job/kwallet-framework_master_qt5/13/changes Changes: [kde] Fix build, once again... -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Jenkins build is back to stable : ktexteditor_master_qt5 #27

2014-01-13 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/27/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/12/2014 07:59 PM, Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a

Re: Integrating kf5dot and kapidox

2014-01-13 Thread Aurélien Gâteau
[Errr... my message got truncated. Let's try again] Now that kf5dot is (hopefully) mostly feature-complete, I think it is time to decide how to integrate it in kapidox. The way kf5dot works is the following: 1. kf5dot-prepare runs CMake on the frameworks source to generate Graphviz dot

Re: Integrating kf5dot and kapidox

2014-01-13 Thread Alex Merry
On 13/01/14 21:36, Aurélien Gâteau wrote: Second, api.kde.org deployment. kf5dot-prepare needs to be able to run CMake on the source code. @Allen: is it possible to do this on api.kde.org? kgenapidox could potentially extract info from the build dir, incidentally. In particular, the generated

Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes

2014-01-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/#review47353 --- Ship it! Looks good to me. - David Edmundson On Jan. 13,

Build failed in Jenkins: kwallet-framework_master_qt5 #14

2014-01-13 Thread KDE CI System
See http://build.kde.org/job/kwallet-framework_master_qt5/14/changes Changes: [kde] Fix build when standalone -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: kwallet-framework_master_qt5 #15

2014-01-13 Thread KDE CI System
See http://build.kde.org/job/kwallet-framework_master_qt5/15/changes Changes: [kde] Attempt fixing build -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Review Request 115005: Install forwarding headers for plain knewstuff3 headers

2014-01-13 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/ --- Review request for KDE Frameworks, David Faure and Jeremy Whiting.

Re: Review Request 114988: Fix PREFIX parameter to ecm_generate_headers to match namespace KNS3

2014-01-13 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114988/ --- (Updated Jan. 13, 2014, 11:39 p.m.) Review request for KDE Frameworks,

Re: Integrating kf5dot and kapidox

2014-01-13 Thread Aurélien Gâteau
On Mon, Jan 13, 2014, at 14:34, Alex Merry wrote: On 13/01/14 21:36, Aurélien Gâteau wrote: Second, api.kde.org deployment. kf5dot-prepare needs to be able to run CMake on the source code. @Allen: is it possible to do this on api.kde.org? kgenapidox could potentially extract info from

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/13/2014 10:05 PM, Valentin Rusu wrote: On 01/12/2014 07:59 PM, Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430