Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53309 --- src/ConfigureChecks.cmake

Re: Review Request 116768: Make our css more future-proof

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116768/#review53310 --- This review has been submitted with commit

Re: Review Request 116768: Make our css more future-proof

2014-03-18 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116768/ --- (Updated March 18, 2014, 10:32 a.m.) Status -- This change has been

Jenkins build is back to normal : krunner_master_qt5 #36

2014-03-18 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/36/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-18 Thread Alexander Richardson
On March 17, 2014, 4:28 p.m., Aurélien Gâteau wrote: src/lib/util/kuser.h, line 216 https://git.reviewboard.kde.org/r/116798/diff/4/?file=254169#file254169line216 I know the review has already been submitted, but shouldn't this be const KUserId uid instead of KUserId uid?

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review53313 --- This review has been submitted with commit

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 18, 2014, 12:17 p.m.) Status -- This change has been

Re: Review Request 116699: No longer use pid_t or Q_PID

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/#review53314 --- This review has been submitted with commit

Re: Review Request 116699: No longer use pid_t or Q_PID

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 18, 2014, 12:19 p.m.) Status -- This change has been

Re: Review Request 116798: Rewrite KUser/KUserGroup Widows implementation + introduce KUserId/KGroupId

2014-03-18 Thread Aurélien Gâteau
On March 17, 2014, 4:28 p.m., Aurélien Gâteau wrote: src/lib/util/kuser.h, line 216 https://git.reviewboard.kde.org/r/116798/diff/4/?file=254169#file254169line216 I know the review has already been submitted, but shouldn't this be const KUserId uid instead of KUserId uid?

Re: RFC on framework localization

2014-03-18 Thread Aurélien Gâteau
On Mon, Mar 17, 2014, at 15:09, Albert Astals Cid wrote: El Dilluns, 17 de març de 2014, a les 08:25:59, Aurélien Gâteau va escriure: On Sat, Mar 15, 2014, at 8:52, Albert Astals Cid wrote: El Divendres, 14 de març de 2014, a les 03:48:49, Aurélien Gâteau va escriure: Hi,

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-18 Thread Aleix Pol
On Tue, Mar 18, 2014 at 4:36 AM, Markus Slopianka kamika...@gmx.de wrote: On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: Now, the last point... What else do we want to move from KDE Frameworks to KDE Porting Aids? Aleix and Aaron proposed the following content for KDE Porting Aids:

Handling of frameworks using Qt-based translations

2014-03-18 Thread Aurélien Gâteau
Hi, I started working on how to handle Qt based translations, and make it as simple as possible to work with for framework maintainers as well as framework users. I picked KBookmarks as my guinea pig and got to the point where kbookmarkdialogtest shows a translated dialog. Here is how it

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-18 Thread Aurélien Gâteau
On Tue, Mar 18, 2014, at 5:37, Aleix Pol wrote: Maybe coming up with the list of modules now is not the most useful thing now. Can we maybe agree that we want an extra value in the framework.yaml file indicating the maturity of the project? +1 Aurélien

Re: Handling of frameworks using Qt-based translations

2014-03-18 Thread Aleix Pol
On Tue, Mar 18, 2014 at 2:05 PM, Aurélien Gâteau agat...@kde.org wrote: Hi, I started working on how to handle Qt based translations, and make it as simple as possible to work with for framework maintainers as well as framework users. I picked KBookmarks as my guinea pig and got to the

Re: Re: Handling of frameworks using Qt-based translations

2014-03-18 Thread Martin Gräßlin
On Tuesday 18 March 2014 14:20:53 Aleix Pol wrote: On Tue, Mar 18, 2014 at 2:05 PM, Aurélien Gâteau agat...@kde.org wrote: Hi, I started working on how to handle Qt based translations, and make it as simple as possible to work with for framework maintainers as well as framework users.

Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- Review request for KDE Frameworks. Repository: kinit Description

Re: Default emoticons theme

2014-03-18 Thread Aleix Pol
On Tue, Mar 18, 2014 at 3:13 PM, Alex Merry alex.me...@kde.org wrote: On 17/03/14 11:57, Alex Merry wrote: On 15/03/14 19:04, Aleix Pol wrote: I do agree that having an emoticons set together with kemoticons can be very helpful and simplify the usage of the module. Also, it doesn't

Re: Handling of frameworks using Qt-based translations

2014-03-18 Thread Aurélien Gâteau
On Tue, Mar 18, 2014, at 6:20, Aleix Pol wrote: On Tue, Mar 18, 2014 at 2:05 PM, Aurélien Gâteau [1]agat...@kde.org wrote: Hi, I started working on how to handle Qt based translations, and make it as simple as possible to work with for framework maintainers as well as framework users. I

KF5 Update Meeting Minutes 2014-w12

2014-03-18 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 12 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, dfaure, mck182, mgraesslin, notmart, PovAddict, Riddell, svuorela, tosky and myself. * afiestas reminds everybody to

Review Request 116876: Add default emoticons theme to kemoticons

2014-03-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/ --- Review request for KDE Frameworks. Repository: kemoticons Description

Re: Handling of frameworks using Qt-based translations

2014-03-18 Thread Aleix Pol
On Tue, Mar 18, 2014 at 4:12 PM, Aurélien Gâteau agat...@kde.org wrote: On Tue, Mar 18, 2014, at 6:20, Aleix Pol wrote: On Tue, Mar 18, 2014 at 2:05 PM, Aurélien Gâteau agat...@kde.org wrote: Hi, I started working on how to handle Qt based translations, and make it as simple as

Re: Handling of frameworks using Qt-based translations

2014-03-18 Thread Aurélien Gâteau
On Tue, Mar 18, 2014, at 9:07, Aleix Pol wrote: On Tue, Mar 18, 2014 at 4:12 PM, Aurélien Gâteau [1]agat...@kde.org wrote: On Tue, Mar 18, 2014, at 6:20, Aleix Pol wrote: On Tue, Mar 18, 2014 at 2:05 PM, Aurélien Gâteau [2]agat...@kde.org wrote: Hi, I started working on how to handle Qt

Re: Review Request 116786: Make error handling more consistent and fail earlier

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/#review53343 --- This review has been submitted with commit

Re: Review Request 116786: Make error handling more consistent and fail earlier

2014-03-18 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/ --- (Updated March 18, 2014, 4:56 p.m.) Status -- This change has been

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:25 a.m.) Review request for KDE Frameworks.

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53347 --- Ship it! Ship It! - Alex Merry On March 18, 2014, 5:25

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53348 --- src/kguiaddons_config.h.cmake

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Michael Hansen
On March 18, 2014, 10:47 a.m., Nicolás Alvarez wrote: src/kguiaddons_config.h.cmake, line 2 https://git.reviewboard.kde.org/r/116866/diff/3/?file=255187#file255187line2 Do these copyright lines really apply to this new file? I think you should include just your own name (since

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:51 a.m.) Status -- This change has been

Re: kde4support = kdelibs4support[Was: Re: Releasing Deprecated modules and Tier 4 Definition]

2014-03-18 Thread Kevin Ottens
Hello, On Monday 17 March 2014 22:53:25 Mario Fux KDE ML wrote: Am Montag, 17. März 2014, 18.15:09 schrieb Kevin Ottens: Porting Aids: * kde4support (obvious); Just that it doesn't get forgotten I'd like to second Aarons (or who it was) proposal to rename kde4support to kdelibs4support

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-18 Thread Kevin Ottens
On Monday 17 March 2014 20:14:24 John Layt wrote: On 17 March 2014 18:15, Kevin Ottens er...@kde.org wrote: I think that list makes sense. Is there anyone who couldn't sleep at night if those were in KDE Porting Aids? +1 to this strategy, although some bikeshedding on the portingaids name

Review Request 116879: Fix build of kuser_win.cpp with MSVC2010

2014-03-18 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116879/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-18 Thread Kevin Ottens
Hello, On Tuesday 18 March 2014 13:37:01 Aleix Pol wrote: On Tue, Mar 18, 2014 at 4:36 AM, Markus Slopianka kamika...@gmx.de wrote: On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: Now, the last point... What else do we want to move from KDE Frameworks to KDE Porting Aids?

QML Bindings for KDE frameworks, take 2

2014-03-18 Thread Marco Martin
Hi all, as I mentioned in the last couple of tuesday meetings, in Plasma we have several QML plugins that don't depend from Plasma at all, but are bound just to either Qt or just one framework (should ideally become the way to use the framework from QML) what we currently have is: * dirmodel:

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-18 Thread Markus Slopianka
On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: Now, the last point... What else do we want to move from KDE Frameworks to KDE Porting Aids? Aleix and Aaron proposed the following content for KDE Porting Aids: * kde4support (obvious); * khtml (planned for a long time); * kjs

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-18 Thread Markus Slopianka
On Tuesday 18 March 2014 13:37:01 Aleix Pol wrote: Can we maybe agree that we want an extra value in the framework.yaml file indicating the maturity of the project? It's not about maturity, it's about security. QtWebKit is no longer maintained by Digia and I am not aware that anybody stepped

Re: QML Bindings for KDE frameworks, take 2

2014-03-18 Thread Kevin Ottens
On Tuesday 18 March 2014 19:37:59 Marco Martin wrote: what we currently have is: * dirmodel: is a binding to kdirmodel - KIO? (i would probably not release it yet but waiting to have folderview done so needed features are more clear) Would make sense in a KIO import indeed. * draganddrop Qt

Re: how to write kded module in framework 5

2014-03-18 Thread Shivam Makkar
On Tue, Mar 18, 2014 at 5:20 AM, Alex Merry alex.me...@kde.org wrote: On 17/03/14 19:35, Shivam Makkar wrote: also I want to know how can i start kded5 when I run command kded5 or kdeinit5 i get kded5(16341)/(default) QXcbSessionManager::QXcbSessionManager: Qt: Session

Re: QML Bindings for KDE frameworks, take 2

2014-03-18 Thread Marco Martin
On Tuesday 18 March 2014, Kevin Ottens wrote: It could be replaced with QGuiApplication::styleHints()-startDragDistance(). It would then have the same dependencies than QtExtraComponents (delta KIconThemes) and could be merged there. Removed qwidgets dependency. The problem i see in

Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)

2014-03-18 Thread Dominik Haumann
Hi, getting an existing directory is still broken with current frameworks integration. A call of: QString dir = QFileDialog::getExistingDirectory(); results in this image: http://wstaw.org/m/2014/03/18/plasma-desktopdF1903.png Whereas what you actually want is this:

Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/ --- (Updated March 18, 2014, 9:14 p.m.) Review request for KDE Frameworks.

Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/ --- (Updated March 18, 2014, 10:20 p.m.) Review request for KDE Frameworks.

Re: Review Request 116879: Fix build of kuser_win.cpp with MSVC2010

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116879/#review53369 --- Ship it! Ship It! - Alexander Richardson On March 18,

Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/#review53370 --- Prefixing the signal with QT_MOC_COMPAT should do the trick,

Re: kde4support = kdelibs4support[Was: Re: Releasing Deprecated modules and Tier 4 Definition]

2014-03-18 Thread Ben Cooksley
On Wed, Mar 19, 2014 at 7:15 AM, Kevin Ottens er...@kde.org wrote: Hello, Hi, On Monday 17 March 2014 22:53:25 Mario Fux KDE ML wrote: Am Montag, 17. März 2014, 18.15:09 schrieb Kevin Ottens: Porting Aids: * kde4support (obvious); Just that it doesn't get forgotten I'd like to second

Re: Review Request 116747: Clean up KCompletionBox

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review53374 --- This review has been submitted with commit

Re: Review Request 116747: Clean up KCompletionBox

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- (Updated March 18, 2014, 10:25 p.m.) Status -- This change has been

Re: Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116792/ --- (Updated March 18, 2014, 10:28 p.m.) Status -- This change has been

Re: Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116792/#review53375 --- This review has been submitted with commit

Re: Review Request 116684: Improve API in KCompletionBase

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116684/#review53376 --- This review has been submitted with commit

Re: Review Request 116684: Improve API in KCompletionBase

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116684/ --- (Updated March 18, 2014, 10:32 p.m.) Status -- This change has been

Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- (Updated March 18, 2014, 11:01 p.m.) Review request for KDE Frameworks.

Review Request 116887: Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116887/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53379 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 18, 2014,

Re: Review Request 116879: Fix build of kuser_win.cpp with MSVC2010

2014-03-18 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116879/ --- (Updated March 19, 2014, 1:47 a.m.) Status -- This change has been

Re: Review Request 116879: Fix build of kuser_win.cpp with MSVC2010

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116879/#review53380 --- This review has been submitted with commit

Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-18 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116883/#review53382 --- A couple questions, one of which needs resolved, but looks

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-03-18 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/#review53383 --- I think I'd argue against bothering with getgrouplist at all