Jenkins build is back to normal : kdeclarative_stable_qt5 #36

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/kdeclarative_stable_qt5/36/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: New framework: KXmlRpcClient

2015-02-12 Thread Albert Astals Cid
El Dijous, 12 de febrer de 2015, a les 12:31:14, Daniel Vrátil va escriure: On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update kde-build-metadata and release-tools and ask for the _stable_qt5 build

Build failed in Jenkins: kdeclarative_master_qt5 #159

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/kdeclarative_master_qt5/159/changes Changes: [hein] Switch press-and-hold from hardcoded 800msecs to platform hint. -- [...truncated 147 lines...] PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH

Build failed in Jenkins: kdeclarative_stable_qt5 #35

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/kdeclarative_stable_qt5/35/changes Changes: [hein] Switch press-and-hold from hardcoded 800msecs to platform hint. -- [...truncated 147 lines...] PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH

Jenkins build is back to normal : kdeclarative_master_qt5 #160

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/kdeclarative_master_qt5/160/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: New framework: KXmlRpcClient

2015-02-12 Thread Daniel Vrátil
On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update kde-build-metadata and release-tools and ask for the _stable_qt5 build once the repo is moved to frameworks on projects.k.o, so that changes don't

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #995

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

2015-02-12 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/#review75906 --- Ship it! KXmlRpcClient is a framework now! - Daniel Vrátil

Re: New framework: KXmlRpcClient

2015-02-12 Thread David Faure
On Thursday 12 February 2015 12:31:14 Daniel Vrátil wrote: On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update kde-build-metadata and release-tools and ask for the _stable_qt5 build once the repo is

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Albert Astals Cid
On feb. 12, 2015, 4:43 p.m., Albert Astals Cid wrote: It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since final will already complain if trying to finalize something that is not overriding a virtual of the parent, no? Kevin Funk wrote: Nitpicker! :D

Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

2015-02-12 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121077/ --- (Updated feb. 12, 2015, 10:56 p.m.) Status -- This change has been

Review Request 122549: Avoid code path that leaves local config files locked

2015-02-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- Review request for KDE Frameworks and Matthew Dawson. Repository:

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

2015-02-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122445/#review75949 --- Guy: ping? - Albert Astals Cid On feb. 5, 2015, 6:36 p.m.,

Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-02-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review75951 --- Patch doesn't apply, please rebase - Albert Astals Cid On

Re: Review Request 121081: QT_WA

2015-02-12 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121081/ --- (Updated Feb. 12, 2015, 10:53 p.m.) Status -- This change has been

Re: Review Request 122194: Initialise all member variables

2015-02-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122194/ --- (Updated feb. 12, 2015, 10:51 p.m.) Status -- This change has been

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2015-02-12 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/ --- (Updated feb. 12, 2015, 10:58 p.m.) Status -- This change has been

Re: Review Request 119567: Also find catalog files that are symlinks

2015-02-12 Thread Luigi Toscano
On Aug. 2, 2014, 1:25 a.m., Luigi Toscano wrote: src/docbookl10nhelper.cpp, line 209 https://git.reviewboard.kde.org/r/119567/diff/1/?file=294859#file294859line209 I'm pretty sure this is not needed: the script is called only during build time between the build directory and the

Re: Review Request 119567: Also find catalog files that are symlinks

2015-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119567/ --- (Updated Feb. 13, 2015, 12:26 a.m.) Status -- This change has been

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75956 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 12, 2015,

Review Request 122551: New feature: Open all recent files

2015-02-12 Thread Thomas Murach
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

Re: Review Request 122551: New feature: Open all recent files

2015-02-12 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/#review75958 --- You're aware that Kate (and any other decent editor) has

Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

2015-02-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository:

Re: Review Request 122549: Avoid code path that leaves local config files locked

2015-02-12 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review75962 --- related bug : https://bugs.kde.org/show_bug.cgi?id=344032 -

Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository:

OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5

2015-02-12 Thread Marko Käning
Hi Albert, I just realised that kde-baseapps fails on OSX/CI when being build for branch group stable-kf5-qt5: -- Group: stable-kf5-qt5 Project : kde/applications/kde-baseapps Branch : Applications/14.12 Linux-CI : UNSTABLE OSX/CI : FAILURE

Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5

2015-02-12 Thread Marko Käning
I just realise that the same happens for these two projects: -- Group: stable-kf5-qt5 Project : kde/kdegraphics/libs/libkdcraw Branch : Applications/14.12 Linux-CI : SUCCESS OSX/CI : FAILURE Prep... Build... : BUILD FAILED

Review Request 122541: KService: fix regression in stringlist properties handling

2015-02-12 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- Review request for KDE Frameworks and Marco Martin. Repository: kservice

Re: Review Request 122541: KService: fix regression in stringlist properties handling

2015-02-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/#review75919 --- unittest? - Albert Astals Cid On feb. 12, 2015, 1:27 p.m.,

Re: Review Request 122541: KService: fix regression in stringlist properties handling

2015-02-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/#review75920 --- discarded? what happened to it? - Marco Martin On Feb. 12,

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

2015-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/ --- (Updated Feb. 12, 2015, 1:54 p.m.) Status -- This change has been

Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- Review request for KDE Frameworks. Description --- This is a huge

Re: Review Request 122541: KService: fix regression in stringlist properties handling

2015-02-12 Thread Marco Martin
On Feb. 12, 2015, 1:49 p.m., Marco Martin wrote: discarded? what happened to it? Martin Klapetek wrote: This happened :) https://git.reviewboard.kde.org/r/122514/ oki (hmm, hope can fix the current test fail in kservice) - Marco

Re: Review Request 122541: KService: fix regression in stringlist properties handling

2015-02-12 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- (Updated Feb. 12, 2015, 2:27 p.m.) Status -- This change has been

Re: Review Request 122541: KService: fix regression in stringlist properties handling

2015-02-12 Thread Martin Klapetek
On Feb. 12, 2015, 2:49 p.m., Marco Martin wrote: discarded? what happened to it? This happened :) https://git.reviewboard.kde.org/r/122514/ - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

2015-02-12 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539/ --- (Updated Feb. 12, 2015, 12:54 p.m.) Status -- This change has been

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
On Feb. 12, 2015, 2:53 p.m., Albert Astals Cid wrote: Is your script smart enough to convert virtual QByteArray data() const; into QByteArray data() const Q_DECL_OVERRIDE; instead of virtual QByteArray data() const Q_DECL_OVERRIDE; Nope. It only deals with

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75926 --- +1 from me (though it would be prettier to also remove

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #996

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #997

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 12, 2015, 3:47 p.m.) Review request for KDE Frameworks.

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75928 --- It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Kevin Funk
On Feb. 12, 2015, 4:43 p.m., Albert Astals Cid wrote: It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since final will already complain if trying to finalize something that is not overriding a virtual of the parent, no? Nitpicker! :D Fixed that one occurence, but